[FFe] [needs packaging] New package libcangjie

[Anthony Wong]

This bug is for a new source package libcangjie. It is licensed under LGPL-3+.

Package can be found in https://launchpad.net/~anthonywong/+archive/ime/+packages.

This package is a library for the Chinese input method Cangjie. I wish this package can be accepted in raring since Cangjie is the most popular input method in Hong Kong. Apart from this package, ibus users will also need ibus-cangjie and pycangjie, which can be found in my PPA.

I will work on uploading to Debian soon but in view of freeze schedule of raring, I am uploading to ubuntu first. There is an ITP for Debian, submitter (subscribed in this bug) has acknowledged this.

Ubuntu Version: Raring
Repo: Universe
Homepage: https://github.com/wanleung/libcangjie

[Iain Lane (laney)]

Sure. Should be OK. Moving to the sponsors team, thanks.

[Sebastien Bacher (seb128)]

I looked at it, some comments:

* "freq-data/getcorpus.cpp: LGPL (v3 or later)
  [Copyright: 2013 Ben Au <benau2006 at yahoo dot com dot hk>]

freq-data/countfreq.sh: LGPL (v3 or later)
  [Copyright: 2013 Ben Au <benau2006 at yahoo dot com dot hk>]"

the copyright holder there should be listed in debian/copyright

* freq-data/quick-classic.txt is under GPL according to debian/copyright, shouldn't the GPL be shipped in the tarball (as COPYING.GPL or similar)?

* debian/rules:
DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)

seems weird, can't you just bump compat to 9 and let dh do its magic?

* debian/control:
- why do you "Pre-Depends: multiarch-support" if you don't use Multi-Arch: same/foreign tags? is the library supposed to be multiarched?
- Standard-Versions current is 3.9.4
- would be nice to wrap build-depends/depends with one items by line, it makes diff easier to read over time

Otherwise it seems fine, I'm not sure any of those is a blocker for upload. Do you need a sponsor for Ubuntu upload?

[Didier Roche-Tolomelli (didrocks)]

* debian/rules:
override_dh_auto_install:
    dh_auto_install

    # Removing unused files
    rm -f debian/tmp/usr/lib/*/*.la

The rm here is done after the file is installed in each debian/<package_name>/

So either switch the order or remove rather debian/*/usr/lib/*/*.la

* Some little picky thing:
W: libcangjie source: build-depends-on-versioned-berkeley-db build-depends:libdb5.3++-dev
W: libcangjie source: missing-license-paragraph-in-dep5-copyright public domain (paragraph at line 46)
W: libcangjie source: out-of-date-standards-version 3.9.3 (current is 3.9.4)

[Anthony Wong (anthonywong)]

Thanks Seb and Didier for the comments. I am dealing with the licensing issue of quick-classic.txt that Seb pointed out with upstream author, hopefully can get it resolved quickly.

[Sebastien Bacher (seb128)]

unsubscribing sponsors, the package is in New: https://launchpad.net/ubuntu/raring/+queue?queue_state=0&queue_text=libcangjie

none of the issues pointed in the reviews are adressed in that upload though, is there any plan to do an update to fix those?

[Anthony Wong (anthonywong)]

Yes, will definitely fix them. Upstream author wants the library to be LGPL so need to sort out the licensing issue.

[Sebastien Bacher (seb128)]

@Anthony: should I reject the current upload while you sort out the licensing issues then?

[Anthony Wong (anthonywong)]

I am fine with that. Hopefully I can sort it out today.

[Anthony Wong (anthonywong)]

The above issues have been fixed and Zhengpeng helped to sponsor the upload.

[Sebastien Bacher (seb128)]

thanks, the new version looks fine to me

[Howard Chan (smartboyhw)]

This package is already approved into the Ubuntu universe repository. Henceforth setting it as "Fix Released".

[Mathieu Bridon (bochecha)]

> The above issues have been fixed and Zhengpeng helped to sponsor the upload.

Anthony, how did you solve the licensing issue with quick-classic.txt?

Can we have your fix sent upstream?

It would have been really better to send your fix upstream first, instead of just fixing things only for Ubuntu. :(