nova-manage throws uncaught exception on invalid host/service

Bug #1154089 reported by Hans Lindgren
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Hans Lindgren

Bug Description

Commands nova-manage service enable/disable with non-exisiting host/service results in an uncaught exception:

2013-03-12 14:31:09.920 CRITICAL nova [req-097d1977-59c0-4812-aeb3-a5d3f10f8b82 None None] Could not find binary nova-compute on host nohost.
2013-03-12 14:31:09.920 TRACE nova Traceback (most recent call last):
2013-03-12 14:31:09.920 TRACE nova File "/usr/local/bin/nova-manage", line 7, in <module>
2013-03-12 14:31:09.920 TRACE nova execfile(__file__)
2013-03-12 14:31:09.920 TRACE nova File "/opt/stack/nova/bin/nova-manage", line 1250, in <module>
2013-03-12 14:31:09.920 TRACE nova main()
2013-03-12 14:31:09.920 TRACE nova File "/opt/stack/nova/bin/nova-manage", line 1242, in main
2013-03-12 14:31:09.920 TRACE nova fn(*fn_args, **fn_kwargs)
2013-03-12 14:31:09.920 TRACE nova File "/opt/stack/nova/bin/nova-manage", line 678, in enable
2013-03-12 14:31:09.920 TRACE nova svc = db.service_get_by_args(ctxt, host, service)
2013-03-12 14:31:09.920 TRACE nova File "/opt/stack/nova/nova/db/api.py", line 155, in service_get_by_args
2013-03-12 14:31:09.920 TRACE nova return IMPL.service_get_by_args(context, host, binary)
2013-03-12 14:31:09.920 TRACE nova File "/opt/stack/nova/nova/db/sqlalchemy/api.py", line 95, in wrapper
2013-03-12 14:31:09.920 TRACE nova return f(*args, **kwargs)
2013-03-12 14:31:09.920 TRACE nova File "/opt/stack/nova/nova/db/sqlalchemy/api.py", line 403, in service_get_by_args
2013-03-12 14:31:09.920 TRACE nova raise exception.HostBinaryNotFound(host=host, binary=binary)
2013-03-12 14:31:09.920 TRACE nova HostBinaryNotFound: Could not find binary nova-compute on host nohost.
2013-03-12 14:31:09.920 TRACE nova

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24175

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/24175
Committed: http://github.com/openstack/nova/commit/071a41f1d052bd01b181e4ae5d6e9aa5f0b39b8b
Submitter: Jenkins
Branch: master

commit 071a41f1d052bd01b181e4ae5d6e9aa5f0b39b8b
Author: Hans Lindgren <email address hidden>
Date: Tue Mar 12 14:42:36 2013 +0100

    Fix: nova-manage throws uncaught exception on invalid host/service

    Add a test case for this too.

    Fix bug 1154089.

    Change-Id: I3a60e581a9fac945fddf72c4f037ca5cae0005fc

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.