vfs/guestfs raising TypeErrors

Bug #1153414 reported by Dan Prince
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Dan Prince

Bug Description

Using the latest Nova grizzly codebase (git 81e2eef).

When booting incompatible images (with no or multiple filestystems, etc) I'm seeing the following exception in nova compute.log:

2013-03-10 21:20:14.203 ERROR nova.compute.manager [req-64973210-d381-4e52-883a-f792ab74fa10 88e044e56439427398f73938b9b75b29 c03bc5e9ec164a49bf39ecfbded6f056] [instance: ee4ac819-1718-4e0d-8755-1a8f93784b97] Error: ['Traceback (most recent call last):\n', ' File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 788, in _run_instance\n injected_files, admin_password)\n', ' File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 1064, in _spawn\n block_device_info)\n', ' File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 1515, in spawn\n admin_pass=admin_password)\n', ' File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 1893, in _create_image\n mandatory=(\'files\',))\n', ' File "/usr/lib/python2.7/site-packages/nova/virt/disk/api.py", line 304, in inject_data\n fs.setup()\n', ' File "/usr/lib/python2.7/site-packages/nova/virt/disk/vfs/guestfs.py", line 106, in setup\n self.setup_os()\n', ' File "/usr/lib/python2.7/site-packages/nova/virt/disk/vfs/guestfs.py", line 50, in setup_os\n self.setup_os_inspect()\n', ' File "/usr/lib/python2.7/site-packages/nova/virt/disk/vfs/guestfs.py", line 69, in setup_os_inspect\n self.imgfile)\n', 'TypeError: __init__() takes at most 2 arguments (3 given)\n']

It looks like we have some incorrectly formatted NovaException's in the code there.

Dan Prince (dan-prince)
Changed in nova:
assignee: nobody → Dan Prince (dan-prince)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24034

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/24034
Committed: http://github.com/openstack/nova/commit/3d7d819f6420857c9e0d31c83a130fc6dc9aff64
Submitter: Jenkins
Branch: master

commit 3d7d819f6420857c9e0d31c83a130fc6dc9aff64
Author: Dan Prince <email address hidden>
Date: Sun Mar 10 21:51:39 2013 -0400

    Correct exception args in vfs/guestfs.

    Updates the exception formatting in vfs/guestfs so that we
    properly raise in cases where there is no root or multiple
    roots.

    Fixes a TypeError that would occur with the previous code.

    Fixes LP Bug #1153414.

    Change-Id: I28f9cde5a2da466ebb7397176baaf051ccd4192b

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.