Transaction: transaction.begin() - synchronizer newTransaction() method called inconsistently

Bug #1153116 reported by Siddhartha Kasivajhula
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ZODB
New
Undecided
Unassigned

Bug Description

For a synchronizer, the newTransaction() method is only called when an explicit call to transaction.begin() is made, and not when a new transaction is implicitly started by a call to transaction.get(). These two cases (explicitly vs implicitly begun transactions) should be treated the same, and newTransaction() should be called in both cases.

Some comments from Jim Fulton on zodb-dev on resolution:

"
Really, ``begin` and ``abort`` are equivalent. It might be better if
there wasn't a ``begin`` method, as it's missleading. One should be an
alias for the other. I'd be for deprecating ``begin``. The call to
``_new_transaction`` should be moved to the point in ``get`` where a
new transaction is created, and ``begin`` should be made an alias for
``abort``.
"

Revision history for this message
Jim Fulton (jim-zope) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.