correct db upgrade column value

Bug #1152546 reported by Yaguang Tang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Dan Smith

Bug Description

Migration 153 adds system_metadata for every instance... containing a copy of the instance_type. However, if the value is Null in instance_types, then after migrate, the correspond value changed to a string "None" , this can cause exceptions when extract instance types.

Tags: db
aeva black (tenbrae)
tags: added: db
Changed in nova:
status: New → Triaged
importance: Undecided → High
milestone: none → grizzly-rc1
Dan Smith (danms)
Changed in nova:
assignee: nobody → Dan Smith (danms)
importance: High → Undecided
milestone: grizzly-rc1 → none
status: Triaged → New
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24391

Changed in nova:
status: New → In Progress
Changed in nova:
assignee: Dan Smith (danms) → Yaguang Tang (heut2008)
Changed in nova:
assignee: Yaguang Tang (heut2008) → Dan Smith (danms)
Sean Dague (sdague)
Changed in nova:
importance: Undecided → High
milestone: none → grizzly-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/24391
Committed: http://github.com/openstack/nova/commit/ed02460ebe08faebc64f1d88aa53cca54f1e45cc
Submitter: Jenkins
Branch: master

commit ed02460ebe08faebc64f1d88aa53cca54f1e45cc
Author: Dan Smith <email address hidden>
Date: Wed Mar 13 20:08:14 2013 -0400

    Fix system_metadata "None" and created_at values

    The ill-fated migration 153 converted None instance_type values to
    "None" in the database instead of properly making them NULL. This
    corrects that by sweeping all of the likely instance_type_% values and
    converting "None" to NULL. Also, it adds a belated created_at stamp
    to all of the items, which was missing in 153 as well.

    It also corrects the 153 migration to avoid polluting things in the
    first place for systems that haven't rolled through that yet.

    Fixes bug 1152546

    Change-Id: I3585463ae15abfd534f2ff070e2974f3cb51d7e8

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.