URL pattern for accounts-view does not allow hyphens
Bug #1151969 reported by
Gavin Panella
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Gavin Panella | ||
1.2 |
Fix Released
|
High
|
Gavin Panella |
Bug Description
The accounts-view URL pattern is defined as:
adminurl(
The username is defined as:
username = forms.RegexFiel
(See django.
However, the URL pattern should probably allow [^/]+ instead of trying
to mirror the form field.
It would also be worth checking other URL patterns.
Related branches
lp:~allenap/maas/accounts-view-patterns
- Raphaël Badin (community): Approve
-
Diff: 35 lines (+10/-3)2 files modifiedsrc/maasserver/tests/test_views_settings.py (+7/-0)
src/maasserver/urls.py (+3/-3)
lp:~rvb/maas/accounts-view-patterns-1.2
- Raphaël Badin (community): Approve
-
Diff: 34 lines (+10/-3)2 files modifiedsrc/maasserver/tests/test_views_settings.py (+7/-0)
src/maasserver/urls.py (+3/-3)
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
> However, the URL pattern should probably allow [^/]+ instead of trying
> to mirror the form field.
I concur, there is no point in trying to be too clever in the url patterns.