Mir

Source code mentions wrong licenses

Bug #1151171 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Robert Ancell
Mir 0.0.3

Bug Description

Throughout src/, we seem to have a mix of GPL and LGPL headers. This should be cleaned up so that the libraries (at least) are LGPL, and binaries (maybe) GPL.

Also, COPYING only mentions GPL. Since most of the source will be LGPL we need to add a COPYING.LGPL.

And of course, in both cases remember we're using *GPL v3.

Related branches

lp:~robert-ancell/mir/fix-licenses
Daniel van Vugt: Needs Fixing
PS Jenkins bot (community): Approve (continuous-integration)
Kevin DuBois (community): Approve
Diff: 1282 lines (+135/-119)
83 files modified
README.md (+1/-1)
debian/copyright (+17/-1)
include/client/mir_toolkit/mir_client_library_drm.h (+1/-1)
include/client/mir_toolkit/mir_client_library_lightdm.h (+1/-1)
include/shared/mir/frontend/client_constants.h (+1/-1)
include/shared/mir/geometry/dimensions.h (+1/-1)
include/shared/mir/geometry/displacement.h (+1/-1)
include/shared/mir/geometry/forward.h (+1/-1)
include/shared/mir/geometry/pixel_format.h (+1/-1)
include/shared/mir/geometry/point.h (+1/-1)
include/shared/mir/geometry/rectangle.h (+1/-1)
include/shared/mir/geometry/size.h (+1/-1)
include/shared/mir/graphics/android/android_driver_interpreter.h (+1/-1)
include/shared/mir/graphics/android/mir_native_window.h (+1/-1)
include/shared/mir/input/android/android_input_lexicon.h (+1/-1)
include/shared/mir/protobuf/google_protobuf_guard.h (+1/-1)
include/shared/mir_toolkit/c_types.h (+1/-1)
include/shared/mir_toolkit/event.h (+1/-1)
include/shared/mir_toolkit/mesa/native_display.h (+3/-3)
src/client/aging_buffer.cpp (+1/-1)
src/client/aging_buffer.h (+1/-1)
src/client/android/android_client_buffer.cpp (+1/-1)
src/client/android/android_client_buffer.h (+1/-1)
src/client/android/android_client_buffer_factory.cpp (+1/-1)
src/client/android/android_client_buffer_factory.h (+1/-1)
src/client/android/android_client_platform.cpp (+1/-1)
src/client/android/android_client_platform.h (+1/-1)
src/client/android/android_native_display_container.cpp (+3/-3)
src/client/android/android_native_display_container.h (+3/-3)
src/client/android/android_registrar.cpp (+1/-1)
src/client/android/android_registrar.h (+1/-1)
src/client/android/android_registrar_gralloc.h (+1/-1)
src/client/android/client_surface_interpreter.cpp (+1/-1)
src/client/android/client_surface_interpreter.h (+1/-1)
src/client/client_buffer.h (+1/-1)
src/client/client_buffer_depository.cpp (+1/-1)
src/client/client_buffer_depository.h (+1/-1)
src/client/client_buffer_factory.h (+1/-1)
src/client/client_context.h (+1/-1)
src/client/client_platform.h (+1/-1)
src/client/client_platform_factory.h (+1/-1)
src/client/egl_native_display_container.h (+3/-3)
src/client/gbm/drm_fd_handler.h (+1/-1)
src/client/gbm/gbm_client_buffer.cpp (+1/-1)
src/client/gbm/gbm_client_buffer.h (+1/-1)
src/client/gbm/gbm_client_buffer_factory.cpp (+1/-1)
src/client/gbm/gbm_client_buffer_factory.h (+1/-1)
src/client/gbm/gbm_client_platform.cpp (+1/-1)
src/client/gbm/gbm_client_platform.h (+1/-1)
src/client/gbm/mesa_native_display_container.cpp (+3/-3)
src/client/gbm/mesa_native_display_container.h (+3/-3)
src/client/input/android_input_platform.cpp (+3/-3)
src/client/input/android_input_platform.h (+3/-3)
src/client/input/android_input_receiver.cpp (+3/-3)
src/client/input/android_input_receiver.h (+3/-3)
src/client/input/android_input_receiver_thread.cpp (+3/-3)
src/client/input/android_input_receiver_thread.h (+3/-3)
src/client/input/input_platform.h (+3/-3)
src/client/input/input_receiver_thread.h (+3/-3)
src/client/make_rpc_channel.h (+1/-1)
src/client/make_socket_rpc_channel.cpp (+1/-1)
src/client/mir_basic_rpc_channel.cpp (+1/-1)
src/client/mir_basic_rpc_channel.h (+1/-1)
src/client/mir_client_library.cpp (+1/-1)
src/client/mir_client_surface.h (+1/-1)
src/client/mir_connection.cpp (+1/-1)
src/client/mir_connection.h (+1/-1)
src/client/mir_logger.cpp (+1/-1)
src/client/mir_logger.h (+1/-1)
src/client/mir_native_buffer.h (+1/-1)
src/client/mir_socket_rpc_channel.cpp (+1/-1)
src/client/mir_socket_rpc_channel.h (+1/-1)
src/client/mir_surface.cpp (+1/-1)
src/client/mir_surface.h (+1/-1)
src/client/mir_wait_handle.cpp (+1/-1)
src/client/mir_wait_handle.h (+1/-1)
src/client/native_client_platform_factory.h (+1/-1)
src/shared/graphics/android/mir_native_window.cpp (+1/-1)
src/shared/graphics/android/syncfence.cpp (+3/-3)
src/shared/graphics/android/syncfence.h (+3/-3)
src/shared/input/CMakeLists.txt (+3/-3)
src/shared/input/android_input_lexicon.cpp (+3/-3)
src/shared/protobuf/google_protobuf_guard.cpp (+1/-1)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Clarification: Right now we're only sure that we want LGPL for the client library. Seems like we may want to keep GPL for server libraries.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Even worse, some files like surfaces/surface.cpp seem to mention both LGPL and GPL.

Revision history for this message
Thomas Voß (thomas-voss) wrote :

In general, we use GPL for binaries, and LGPL for libraries.

I checked on src/server/surfaces/surface.cpp and only found LGPL. Could you please confirm that the issue is resolved?

Changed in mir:
status: New → Confirmed
milestone: none → 0.0.3
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.0.3

Changed in mir:
status: Confirmed → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

didrocks' branch is not a fix for this bug. So unlinking the branch.

I can still see GPL headers in a lot of library sources:
    grep -lr 'GNU General' src

Changed in mir:
assignee: nobody → Didier Roche (didrocks)
status: Fix Committed → Confirmed
assignee: Didier Roche (didrocks) → nobody
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

@Daniel: that's what I told when submitting the branch ;)
Yeah, feel free to continue sedding in the files to get all headers under LGPL. (that's the safest path after discussing with Thomas).

Do not forget to update debian/copyright to reflect that as well. Something I didn't get time to look at.

Daniel van Vugt (vanvugt)
Changed in mir:
assignee: nobody → Robert Ancell (robert-ancell)
status: Confirmed → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.0.3

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Not fixed yet. src/server/* has yet to be corrected.

Changed in mir:
status: Fix Committed → Triaged
Revision history for this message
Robert Ancell (robert-ancell) wrote :

I clarified with Mark and he said libmirserver should remain GPL.

Changed in mir:
status: Triaged → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK, I've opened a new bug 1168225 for related license problems.

Robert Ancell (robert-ancell)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.