archive_deleted_rows default row count is not listed

Bug #1151064 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Joe Gordon

Bug Description

nova.db.sqlalchemy.api.archive_deleted_rows has a default max_rows value of 5,000, however this is an inline constant, is not configurable, and is not displayed to a user who runs "nova-manage help"! It is defined here:

  https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L4719

Instead, I think this should be a default value set within nova-manage for the corresponding archive command.

Tags: db
aeva black (tenbrae)
tags: added: db
Changed in nova:
status: New → Confirmed
aeva black (tenbrae)
Changed in nova:
importance: Undecided → Low
description: updated
Joe Gordon (jogo)
Changed in nova:
assignee: nobody → Joe Gordon (jogo)
Changed in nova:
status: Confirmed → In Progress
Joe Gordon (jogo)
Changed in nova:
milestone: none → grizzly-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/23496
Committed: http://github.com/openstack/nova/commit/abc0c9479127671adf8fcd81197ab993356cbc6a
Submitter: Jenkins
Branch: master

commit abc0c9479127671adf8fcd81197ab993356cbc6a
Author: Joe Gordon <email address hidden>
Date: Tue Mar 5 01:11:45 2013 +0000

    Make nova-manage db archive_deleted_rows more explicit

    * max_rows must be positive
        Provide a better error message of 'nova-manage db archive_deleted_rows
        --max_rows=' is negative.
    * Requires a max_rows
    * No hidden default of 5000

    Fix bug 1145609
    Fix bug 1151064

    Change-Id: I9078ff2700a0329ac4aff68bb434be5f16a5a3f1

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.