nova domain leaking into other domains

Bug #1150194 reported by Neela Shah
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Unassigned

Bug Description

Overriding the builtin namespace causes the nova domain to leak into other modules when looking up messages.

when nova calls something in glance and there is a message needed it overrides the '_' function used for the message lookup and redirects glance to look for the message in the nova message file and the message is not found.

To fix this problem, every file should be importing their own '_' function so that it only gets messages for its own 'domain'.

Revision history for this message
Chuck Short (zulcss) wrote :

Which version is this with?

Changed in nova:
status: New → Incomplete
Revision history for this message
Neela Shah (neela) wrote :

This is with grizzly.

Changed in nova:
status: Incomplete → New
Chuck Short (zulcss)
Changed in nova:
status: New → Triaged
Revision history for this message
Mathew Odden (locke105) wrote :

The issue isn't limited to just overriding the '_' function for glance client, but for any library that calls into. Also, the interference works both ways, the other libraries can replace the '_' function installed in the _builtin_ namespace which in turn causes issues when flow of control gets back to nova.

Revision history for this message
Joe Gordon (jogo) wrote :

each module now imports its own _

Changed in nova:
status: Triaged → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.