Network Administration Visualized

Auto-recognize HTTP URLs in reports and hyperlink them

Bug #1149160 reported by John-Magne Bredal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Network Administration Visualized
Fix Released
Wishlist
John-Magne Bredal
Network Administration Visualized 4.3.0

Bug Description

If there are links in the opt fields in rooms they are clickable in /info/room. This is also wanted in the room report.

Revision history for this message
John-Magne Bredal (john-m-bredal) wrote :

There is no quick fix for this as the fix done in /info/room was to just add urlize to the fields. As the report does not use django templates this is not as easy.

Changed in nav:
importance: Undecided → Wishlist
John-Magne Bredal (john-m-bredal)
Changed in nav:
milestone: none → 4.3.0
status: New → Fix Committed
Revision history for this message
John-Magne Bredal (john-m-bredal) wrote :

It was very solvable. It turns out that if you think about something for two years and simultaneously increase your experience in related fields, a solution will present itself. Maybe.

Fix here:
https://nav.uninett.no/hg/default/rev/4e6d0d3c7eb6

Revision history for this message
Morten Brekkevold (mbrekkevold) wrote :

And you are sure this does not enable some funny exploits when displaying reports with raw data collected from the network?

Changed in nav:
assignee: nobody → John-Magne Bredal (john-m-bredal)
Morten Brekkevold (mbrekkevold)
summary: - report room clickable links in opt fields
+ Auto-recognize HTTP URLs in reports and hyperlink them
Morten Brekkevold (mbrekkevold)
Changed in nav:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.