migration 153 creates deleted=NULL columns

Bug #1147839 reported by Chris Behrens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Critical
Chris Behrens

Bug Description

Migration 153 adds system_metadata for every instance... containing a copy of the instance_type. However, it doesn't create entries with 'deleted' set.... so they default to NULL in mysql. deleted should be explicitly set to 0, instead.

When instance_get* joins system_metadata, all of these new entries are not there, because NULL does not match deleted=0 when joining.

Chris Behrens (cbehrens)
Changed in nova:
status: New → Triaged
importance: Undecided → Critical
milestone: none → grizzly-rc1
Chris Behrens (cbehrens)
Changed in nova:
assignee: nobody → Chris Behrens (cbehrens)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23627

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/23627
Committed: http://github.com/openstack/nova/commit/12d362b4ca324c589918a36ba332ee54a62caf9f
Submitter: Jenkins
Branch: master

commit 12d362b4ca324c589918a36ba332ee54a62caf9f
Author: Chris Behrens <email address hidden>
Date: Tue Mar 5 14:45:33 2013 -0800

    Fix instance_system_metadata deleted columns

    Migration 153 adds instance_type data to sys_meta, but creates entries
    with the default value of deleted.. which is NULL. This means these
    entries do not get pulled in on a join when querying an instance, as
    there is a condition of deleted=0.

    This converts 'deleted' NULL entries to be 0.

    Fixes bug 1147839

    Change-Id: I3caf92b3992b22089a2653c2e7220585d616a102

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.