Unnecessary import of keyring leads to spurious "Failed to load keyring modules." messages

Bug #1145071 reported by Davanum Srinivas (DIMS)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Medium
Davanum Srinivas (DIMS)

Bug Description

in a server environement where there are no keyrings, i still keep getting "Failed to load keyring modules." even on a simple "keystone --help". This is very irritating.

Looking at the code if use_keyring is false, we should not even be trying to load keyrings!!!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23461

Changed in python-keystoneclient:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/23461
Committed: http://github.com/openstack/python-keystoneclient/commit/06d9437e8388b369546d760607f17cb5022750e9
Submitter: Jenkins
Branch: master

commit 06d9437e8388b369546d760607f17cb5022750e9
Author: Davanum Srinivas <email address hidden>
Date: Mon Mar 4 14:46:32 2013 -0500

    Work better in server env with no keyrings

    We should not try loading keyrings if we dont' have to. We
    certainly should not print messages if keyrings are not even
    needed

    Fix for LP# 1145071

    Change-Id: I700a2b40620359f6f1fbe03c6a6239d162ddea61

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → Medium
status: Fix Committed → Fix Released
milestone: none → 0.2.3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.