Peopledirectory: report group ordering broken

Bug #1144889 reported by Tres Seaver
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Medium
Tres Seaver

Bug Description

When trying to move an item up in a report group contents view.

AttributeError: 'OOBTreeItems' object has no attribute 'index'
Exception when processing https://karl.soros.org/people/foundations/c2/spin-offs/moveup.html?name=open-society-fund-prague
Referer: https://karl.soros.org/people/foundations/c2/spin-offs/admin.html

Traceback (most recent call last):
  File "/srv/osfkarl/production/13/eggs/pyramid-1.2.1-py2.6.egg/pyramid/tweens.py", line 17, in excview_tween
    response = handler(request)
  File "/srv/osfkarl/production/13/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 107, in tm_tween
    return response
  File "/srv/osfkarl/production/13/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 75, in __exit__
    return self._retry_or_raise(t, v, tb)
  File "/srv/osfkarl/production/13/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 60, in _retry_or_raise
    reraise(t, v, tb) # otherwise reraise the exception
  File "/srv/osfkarl/production/13/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 100, in tm_tween
    response = handler(request)
  File "/srv/osfkarl/production/13/eggs/pyramid-1.2.1-py2.6.egg/pyramid/router.py", line 153, in handle_request
    response = view_callable(context, request)
  File "/srv/osfkarl/production/13/eggs/pyramid-1.2.1-py2.6.egg/pyramid/config/views.py", line 186, in _secured_view
    return view(context, request)
  File "/srv/osfkarl/production/13/eggs/pyramid-1.2.1-py2.6.egg/pyramid/config/views.py", line 292, in rendered_view
    result = view(context, request)
  File "/srv/osfkarl/production/13/eggs/karl-3.104-py2.6.egg/karl/views/peopledirectory.py", line 104, in admin_contents_moveup_view
    n = order.index(name)
AttributeError: 'OOBTreeItems' object has no attribute 'index'

Tres Seaver (tseaver)
Changed in karl3:
milestone: none → m125
assignee: nobody → Tres Seaver (tseaver)
importance: Undecided → Medium
milestone: m125 → none
Revision history for this message
Tres Seaver (tseaver) wrote :

I need to fix this issue in order to implement https://bugs.launchpad.net/karl3/+bug/1131934 correctly.

Changed in karl3:
milestone: none → m125
status: New → Confirmed
Revision history for this message
Tres Seaver (tseaver) wrote :

Fix committed on 'tseaver-1144889-peopledir_ordering' branch.

Changed in karl3:
status: Confirmed → Fix Committed
Revision history for this message
Tres Seaver (tseaver) wrote :

I just tested the 'move up' and 'move down' features on karlstaging (/people/admin.html), after merging the branch to the 'm125' integration branch. All is well.

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Yep, I tested also.

Tres Seaver (tseaver)
Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.