Issues found in Cinder /os-hosts API

Bug #1139984 reported by Feilong Wang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Feilong Wang

Bug Description

There are some issues found in Cinder /os-hosts API.

1) Bracket in the wrong spot in Cinder HostController show method
   There is an erroneous bracket on the following line in the show method that shoudl be at the end of the response:
     'total_volume_gb': str(sum)},

2) XML Attributes Missing for List/Index method in Cinder HostController
   The HostIndexTemplate class specifies mapping for "host" and "topic" attributes rather than any of the ones that are actually returned from the index method. This needs to be updated to map host_name, service, zone, service-status, service-state and last-update attributes

3) XML Serialization Not Implemented for Cinder HostController show method
   The "wsgi.serializers(xml=HostShowTemplate)" decorator is commented out on the show method, so this doesn't end up allowing XML to be be fully returned for additional attributes added. This needs to be uncommented

Feilong Wang (flwang)
Changed in cinder:
assignee: nobody → Fei Long Wang (flwang)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23361

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/23361
Committed: http://github.com/openstack/cinder/commit/6d2693a13e9b33da6b13e13f587f99a20b2fe2d0
Submitter: Jenkins
Branch: master

commit 6d2693a13e9b33da6b13e13f587f99a20b2fe2d0
Author: Fei Long Wang <email address hidden>
Date: Sun Mar 3 16:48:22 2013 +0800

    Fixes issues found in /os-hosts API

    There are some issues found in Cinder /os-hosts API:

    1) Bracket in the wrong spot in Cinder HostController show method
    There is an erroneous bracket on the following line in the show method
    that should be at the end of the response:
       'total_volume_gb': str(sum)},

    2) XML Attributes Missing for List/Index method in Cinder HostController
    The HostIndexTemplate class specifies mapping for "host" and "topic"
    attributes rather than any of the ones that are actually returned from
    the index method.

    3) XML Serialization is commented for Cinder HostController show method

    Fixes Bug: 1139984

    Change-Id: I881e80b5e109ed6ddcc4f7c4bf5749ab6dca563d

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.