mir_toolkit namespace around client API functions is pointless
Bug #1137184 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Undecided
|
Alan Griffiths |
Bug Description
Recently the mir_toolkit namespace was added and it was applied to client API functions too:
src/
mir_
Although the client header says 'extern "C"' so the namespace is not emitted in the compiled output:
nm lib/libmirclien
00000000000
This means all the messiness of mentioning "mir_toolkit::" in mir_client_
Related branches
lp:~alan-griffiths/mir/fix-bug-1137170
- PS Jenkins bot (community): Approve (continuous-integration)
- Daniel van Vugt: Needs Fixing
- Kevin DuBois (community): Approve
- Alexandros Frantzis (community): Approve
-
Diff: 1313 lines (+170/-164)35 files modifiedinclude/client/mir_toolkit/mir_client_library.h (+4/-5)
include/client/mir_toolkit/mir_client_library_drm.h (+5/-2)
include/client/mir_toolkit/mir_client_library_lightdm.h (+5/-2)
include/shared/mir_toolkit/c_types.h (+5/-2)
include/shared/mir_toolkit/common.h (+6/-1)
include/shared/mir_toolkit/input/event.h (+5/-0)
include/shared/mir_toolkit/mesa/native_display.h (+5/-3)
src/client/android/android_client_buffer_factory.cpp (+1/-1)
src/client/android/android_client_buffer_factory.h (+1/-1)
src/client/android/android_native_display_container.cpp (+6/-6)
src/client/android/android_native_display_container.h (+3/-3)
src/client/client_buffer.h (+6/-4)
src/client/client_buffer_depository.cpp (+1/-1)
src/client/client_buffer_depository.h (+1/-6)
src/client/client_buffer_factory.h (+1/-1)
src/client/client_context.h (+2/-8)
src/client/egl_native_display_container.h (+3/-3)
src/client/gbm/gbm_client_buffer.cpp (+2/-2)
src/client/gbm/gbm_client_buffer.h (+3/-3)
src/client/gbm/gbm_client_buffer_factory.cpp (+1/-1)
src/client/gbm/gbm_client_buffer_factory.h (+1/-1)
src/client/gbm/gbm_client_platform.cpp (+1/-1)
src/client/gbm/mesa_native_display_container.cpp (+9/-9)
src/client/gbm/mesa_native_display_container.h (+4/-4)
src/client/mir_client_library.cpp (+31/-31)
src/client/mir_client_surface.h (+2/-2)
src/client/mir_connection.cpp (+23/-23)
src/client/mir_connection.h (+1/-1)
src/client/mir_surface.cpp (+19/-19)
src/client/mir_surface.h (+1/-1)
src/client/mir_wait_handle.cpp (+5/-5)
src/client/mir_wait_handle.h (+5/-3)
tests/unit-tests/client/gbm/test_mesa_native_display_container.cpp (+1/-1)
tests/unit-tests/client/test_aging_buffer.cpp (+1/-6)
tests/unit-tests/client/test_wait_handle.cpp (+0/-2)
Changed in mir: | |
assignee: | Alan Griffiths (alan-griffiths) → nobody |
information type: | Proprietary → Public |
Changed in mir: | |
status: | New → Fix Committed |
Changed in mir: | |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
Changed in mir: | |
milestone: | none → 0.0.3 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
It is not pointless - it just doesn't change the linkage.
It permits C++ code to refer to use the namespace for disambiguation, and it cleanly separates the API in the generated Docygen docs.