libgeda: Remove dead code

Bug #1135845 reported by Roland Lutz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Undecided
Roland Lutz

Bug Description

The bounding box of a pin has PIN_WIDTH_NET / 2 extra space in all
directions (see world_get_line_bounds in o_line_basic.c).

Revision history for this message
Roland Lutz (rlutz) wrote :
Revision history for this message
Vladimir Zhbanov (vzhbanov) wrote :

AFAICS, the patch just deletes two comparison blocks where
endpoint coordinates of a pin are compared with coordinates of its
boundbox.
Since the calculation is done only for pin objects which bounds
are always outside their endpoint coordinates so these comparisons
of equality make no sense.

The patch should be applied after the patch in #1135833.

Changed in geda:
status: New → Confirmed
Revision history for this message
Roland Lutz (rlutz) wrote :

Patch committed as c59ea5789e57df813ef7d84d78592a6a0b0d341e

Changed in geda:
assignee: nobody → Roland Lutz (rlutz)
status: Confirmed → Fix Committed
Peter TB Brett (peter-b)
Changed in geda:
milestone: none → 1.9.1
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.