libgeda: Fix typo in o_pin_update_whichend
Bug #1135833 reported by
Roland Lutz
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| gEDA |
Fix Released
|
Undecided
|
Roland Lutz | ||
Bug Description
Example symbol reproducing the bug:
v 20020825
P 305 0 305 100 1
P 305 200 305 300 1
Revision history for this message
| Roland Lutz (rlutz) wrote | #1 |
Revision history for this message
| Vladimir Zhbanov (vzhbanov) wrote | #2 |
| Changed in geda: | |
| status: | New → Confirmed |
Revision history for this message
| Roland Lutz (rlutz) wrote | #3 |
| Changed in geda: | |
| assignee: | nobody → Roland Lutz (rlutz) |
| status: | Confirmed → Fix Committed |
| Changed in geda: | |
| milestone: | none → 1.9.1 |
| Changed in geda: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is a very long standing bug which is difficult to discover,
especially these days. You have to find such and old symbol before.
The issue is discoverable only when Y of a vertical pin is
equal to (X + 5) where 5 is defined by the pin bounds. All other
cases I tried do not reveal this bug.
To reproduce the bug, open the above symbol in gschem or add it
to a schematic. The direction of the top pin is reverse while
normally its connection point should be at the top of the symbol.
The patch fixes the issue, it is simple and applies cleanly to git
master HEAD (1814f28ac24658
So please commit it.