Catch all error trap in editsongform.py, _processLyrics
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
OpenLP | Status tracked in Trunk | |||||
2.0 |
Fix Released
|
High
|
Phill | |||
Trunk |
Fix Released
|
High
|
Phill |
Bug Description
Hi,
I have been investigating a bug that has been reported on the support tracker (http://
I have seen reports like this before on the support tracker, but have only just been able to narrow it down thanks to this comment: https:/
It appears that this catch all maybe responsible for us being unable to fix several different bugs.
So as Jonathan says:
" We shouldn't ignore/hide these errors, and ideally want to fix the original cause."
"Either that or re-throw the error"
I've created this separate report as Jonathan's comments were kind of hidden, but to me seem quite important.
Related branches
- Tim Bentley: Approve
- Andreas Preikschat (community): Approve
-
Diff: 8 lines (+1/-0)1 file modifiedopenlp/plugins/songs/forms/editsongform.py (+1/-0)
- OpenLP Core: Pending requested
-
Diff: 1331 lines (+778/-14) (has conflicts)19 files modifiedopenlp/.version (+4/-0)
openlp/core/__init__.py (+15/-0)
openlp/core/lib/__init__.py (+17/-0)
openlp/core/lib/eventreceiver.py.OTHER (+293/-0)
openlp/core/lib/mediamanageritem.py (+9/-0)
openlp/core/lib/serviceitem.py (+17/-0)
openlp/core/lib/settings.py (+68/-0)
openlp/core/lib/settingsmanager.py.OTHER (+168/-0)
openlp/core/ui/aboutdialog.py (+6/-0)
openlp/core/ui/mainwindow.py (+13/-0)
openlp/core/ui/media/vendor/vlc.py (+1/-1)
openlp/core/ui/slidecontroller.py (+18/-0)
openlp/plugins/songs/forms/editsongform.py (+29/-0)
openlp/plugins/songs/lib/__init__.py (+7/-0)
openlp/plugins/songs/lib/ewimport.py (+22/-6)
openlp/plugins/songs/lib/songimport.py (+2/-1)
openlp/plugins/songs/lib/songshowplusimport.py (+13/-6)
scripts/check_dependencies.py (+6/-0)
scripts/openlp-remoteclient.py.OTHER (+70/-0)
- Tim Bentley: Approve
- Andreas Preikschat (community): Approve
-
Diff: 11 lines (+1/-0)1 file modifiedopenlp/plugins/songs/forms/editsongform.py (+1/-0)
tags: | added: song support-system |