TestAuthInfo class in test_v3_auth could be more efficient

Bug #1134836 reported by Henry Nash
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
Ajaya Agrawal

Bug Description

These tests are somewhat inefficient, since by using the test_v3.RestfulTestCase class to gain access to the auth building helper functions, they cause backend databases and fixtures to be loaded unnecessarily. Separating out the helper functions from . this base class would improve efficiency

Henry Nash (henry-nash)
Changed in keystone:
importance: Undecided → Medium
importance: Medium → Low
Revision history for this message
Dolph Mathews (dolph) wrote :

I think the databases should be loaded but 'default_fixtures' should not.

Dolph Mathews (dolph)
Changed in keystone:
importance: Low → Wishlist
Dolph Mathews (dolph)
Changed in keystone:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/98072

Changed in keystone:
assignee: nobody → Ajaya Agrawal (ajayaa)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/98072
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=9722281cd7c720275e0e18b016428510bdbb27e4
Submitter: Jenkins
Branch: master

commit 9722281cd7c720275e0e18b016428510bdbb27e4
Author: ajayaa <email address hidden>
Date: Thu Jun 5 15:15:54 2014 +0530

    TestAuthInfo class in test_v3_auth made more efficient.

    The TestAuthInfo class inheriting from class RestfulTestCase
    is ineffcient because it causes backend databases and
    fixtures to be loaded unnecessarily.

    Moved auth building helper functions from RestfulTestCase to a new
    class AuthTestMixin

    Change-Id: If5c187e4f2a5871fd9ad41d90de4d5ddecd75153
    Closes-Bug: #1134836

Changed in keystone:
status: In Progress → Fix Committed
Changed in keystone:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.