Drop support for lcms1

Bug #1133014 reported by Alex Valavanis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
Qantas94Heavy

Bug Description

We currently have 168 conditional code blocks for supporting the obsolete lcms1 library. This has already been replaced in all supported linux distros by lcms2.

For the sake of maintainability, we should aim to support only lcms2. I have opened a separate report (bug #1133006), requesting that devlibs is updated to lcms2.

Would anyone object to dropping lcms1 support once devlibs is updated?

Changed in inkscape:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
su_v (suv-lp) wrote :

> Would anyone object to dropping lcms1 support once devlibs is updated?

Yes - lcms2 is not yet supported on OS X (see configure.ac)

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

> lcms2 is not yet supported on OS X (see configure.ac)

Ah... good to know! Would it be worth adding information about OS X to the Tracking Dependencies table on the Wiki? [1] It's a bit of a pain to maintain, but it really helps with keeping track of this stuff.

[1] http://wiki.inkscape.org/wiki/index.php/Tracking_Dependencies#Distros

Revision history for this message
su_v (suv-lp) wrote :

> Would it be worth adding information about OS X to the
> Tracking Dependencies table on the Wiki?

Not sure the info about available lcms versions (e.g. in MacPorts) would be helpful in this case: AFAIU it's an issue within Inkscape, not with the OS X port of lcms2 per se (lcms2 already is used e.g. with recent poppler and ImageMagick versions, see also bug #1024344). Unfortunately Jon Cruz hasn't been very active for Inkscape lately, after having implemented support for lcms2 for bug #885324 in revision 10969 ("Enable LCMS2 for other than OSX, where it still has some issues."):
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/10969>

> [1] http://wiki.inkscape.org/wiki/index.php/Tracking_Dependencies#Distros

<http://wiki.inkscape.org/wiki/index.php/Talk:Tracking_Dependencies>

OTOH I'm not so sure whether tracking one (of several available) package management systems on OS X is that useful (even if MacPorts is the one officially recommended with the current osx packaging scripts and compile instructions in the wiki): MacPorts doesn't have a global 'version' which includes a certain state/version for all packages: a few well maintained ports are updated frequently, others not so, and for continuously having a stable build setup e.g. for inkscape trunk, it can quickly get rather cumbersome (especially if updates break other ports)). This situation often results in delaying certain or all updates for extended periods of time, thus partially relying on older versions than actually being available.

Revision history for this message
su_v (suv-lp) wrote :

LCMS2 support has been enabled for OS X build in revision 13620:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/13620#configure.ac>

Revision history for this message
Qantas94Heavy (qantas94heavy) wrote :

Should we target dropping support for LCMS1 for Inkscape 1.0? Or are there still issues with doing that?

Changed in inkscape:
assignee: nobody → Qantas94Heavy (qantas94heavy)
status: Triaged → In Progress
milestone: none → 1.0
Revision history for this message
Qantas94Heavy (qantas94heavy) wrote :
Changed in inkscape:
status: In Progress → Fix Committed
tbnorth (terry-n-brown)
tags: added: bug-migration
Max Gaukler (mgmax)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.