Need to follow new method signature for hyper-v driver

Bug #1132772 reported by Feilong Wang
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Alessandro Pilotti

Bug Description

Now in Grizzly the method signature of "destory" for compute driver is as below:

def destroy(self, instance, network_info, block_device_info=None,
            destroy_disks=True):

But the hyper-v driver is still using the follow:

def destroy(self, instance, network_info=None, cleanup=True,
            destroy_disks=True):

Which will cause the destroy failure.

Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23239

Changed in nova:
assignee: nobody → Alessandro Pilotti (alexpilotti)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/23239
Committed: http://github.com/openstack/nova/commit/d1414c8a4f44484a4b4c39d9ba5f8a9d386f696b
Submitter: Jenkins
Branch: master

commit d1414c8a4f44484a4b4c39d9ba5f8a9d386f696b
Author: Alessandro Pilotti <email address hidden>
Date: Fri Mar 1 02:23:48 2013 +0200

    Fixes the Hyper-V driver's method signature

    Fixes Bug: 1132772

    Corrects an issue in the Hyper-V driver's destroy method argument list.

    Change-Id: Ieb15df80a2d3738a46f7bdd56ba0de57b68fac14

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.