cdbs should depend on devscripts

[Evan Klitzke]

Binary package hint: cdbs

If you install cdbs without installing the devscripts package you will get an error when running cdbs-edit-patch because debclean is not present. debclean is provided by devscripts, so cdbs should have a dependency on devscripts.

[Steve Langasek (vorlon)]

On Thu, Sep 08, 2005 at 03:12:54AM +0200, Peter Eisentraut wrote:
> Package: cdbs
> Version: 0.4.32
> Severity: serious
> Justification: violation of release policy (clause 2)

> The command cdbs-edit-patch requires the command debclean to operate, which
> is in package devscripts, but there is no dependency or other
> relationship declared to that package.

Strictly speaking, opportunistic dependencies are allowed; if a package
includes optional utilities that are not required for the main purpose
of the package, it is generally considered acceptable to not list the
dependencies of those optional utilities.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
<email address hidden> http://www.debian.org/

[Marc Dequènes (Duck) (duck)]

severity 327151 normal
thanks

Vorlon is right, this script is optionnal, or even extra-optionnal, and
thus adding a Suggests line would be sufficient.

--
Marc Dequènes (Duck)

[Peter Eisentraut (petere)]

I suggest that the following be applied. This removes the devscripts
dependency altogether, as it's not needed.

diff -Nru /tmp/BKSAoZWDbV/cdbs-0.4.32/scripts/cdbs-edit-patch /tmp/15PktvE0NM/cdbs-0.4.33/scripts/cdbs-edit-patch
--- /tmp/BKSAoZWDbV/cdbs-0.4.32/scripts/cdbs-edit-patch 2005-04-20 14:01:34.000000000 +0200
+++ /tmp/15PktvE0NM/cdbs-0.4.33/scripts/cdbs-edit-patch 2005-11-30 00:02:24.000000000 +0100
@@ -22,7 +22,7 @@
 # create clean source package in temporary dir
 cp -a . $TMP/$ORIGDIR
 cd $TMP/$ORIGDIR
-debclean
+debian/rules clean

 # create an empty patch if necessary so that the following loop stops at the
 # lexicographic patch position

[Peter Eisentraut (petere)]

# Automatically generated email from bts, devscripts version 2.9.8
tags 327151 + patch

[Peter Eisentraut (petere)]

Source: cdbs
Source-Version: 0.4.33

We believe that the bug you reported is fixed in the latest version of
cdbs, which is due to be installed in the Debian FTP archive:

cdbs_0.4.33.dsc
  to pool/main/c/cdbs/cdbs_0.4.33.dsc
cdbs_0.4.33.tar.gz
  to pool/main/c/cdbs/cdbs_0.4.33.tar.gz
cdbs_0.4.33_all.deb
  to pool/main/c/cdbs/cdbs_0.4.33_all.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Peter Eisentraut <email address hidden> (supplier of updated cdbs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 4 Feb 2006 00:07:53 +0100
Source: cdbs
Binary: cdbs
Architecture: source all
Version: 0.4.33
Distribution: unstable
Urgency: low
Maintainer: CDBS Hackers <email address hidden>
Changed-By: Peter Eisentraut <email address hidden>
Description:
 cdbs - common build system for Debian packages
Closes: 260408 281053 282959 284231 285244 294537 301667 311517 327151 338625 344383
Changes:
 cdbs (0.4.33) unstable; urgency=low
 .
   * Added myself to uploaders
   * Allow specifying a makefile (makefile-vars.mk) (closes: #282959)
   * Skip cleaning if DEB_MAKE_CLEAN_TARGET is unset (makefile.mk)
     (closes: #338625)
   * Add unpatch target for dpatch-edit-patch (dpatch.mk) (closes: #284231)
   * Remove debian/patched/ on clean (dpatch.mk) (closes: #285244)
   * Remove leading comma in Build-Depends line (buildcore.mk)
     (closes: #294537)
   * Propagate CPPFLAGS (autotools-vars.mk) (closes: #301667)
   * Recognize "changelog" as upstream changelog name (debhelper.mk)
     (closes: #311517)
   * cdbs-edit-patch: Use debian/rules clean instead of debclean
     (closes: #327151)
   * cdbs-edit-patch: Create debian/patches directory (closes: #344383)
   * Fix typo in documentation (closes: #260408)
   * Add missing parentheses in python-distutils.mk (closes: #281053)
Files:
 1ac84228eab2ff1dc5eaeed9439545c1 1067 devel optional cdbs_0.4.33.dsc
 0491bf556197f0a7e870045ff32ae34a 203479 devel optional cdbs_0.4.33.tar.gz
 6c574a0680bec19d6a91a7b867e96dd6 335332 devel optional cdbs_0.4.33_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD5HEATTx8oVVPtMYRAoeNAKC1K9Yfw/r9YkqEk6woNrGzULB4JwCfZCyA
gD46/L+bKwEhZ3ud73LIoXs=
=nWLB
-----END PGP SIGNATURE-----

[Evan Klitzke (eklitzke2)]

Binary package hint: cdbs

If you install cdbs without installing the devscripts package you will get an error when running cdbs-edit-patch because debclean is not present. debclean is provided by devscripts, so cdbs should have a dependency on devscripts.

[Sebastien Bacher (seb128)]

the bug is fixed in gutsy