TPac: copies record display should sort by normalized call number

Bug #1131889 reported by Galen Charlton
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Consider a encyclopedia with 10 volumes that are assigned the following call numbers:

AE5 .E363 1975 v.1
AE5 .E363 1975 v.2
AE5 .E363 1975 v.3
AE5 .E363 1975 v.4
AE5 .E363 1975 v.5
AE5 .E363 1975 v.6
AE5 .E363 1975 v.7
AE5 .E363 1975 v.8
AE5 .E363 1975 v.9
AE5 .E363 1975 v.10

The copy list in TPac will sort them by label, which is not the desired sort order:

AE5 .E363 1975 v.1
AE5 .E363 1975 v.10
AE5 .E363 1975 v.2
AE5 .E363 1975 v.3
AE5 .E363 1975 v.4
AE5 .E363 1975 v.5
AE5 .E363 1975 v.6
AE5 .E363 1975 v.7
AE5 .E363 1975 v.8
AE5 .E363 1975 v.9

They should be sorted by the call number label sortkey, which (at least for volume records using the LC normalizer) will give the correct order.

Evergreen master

Revision history for this message
Galen Charlton (gmc) wrote :

A patch for this is available in the collab/gmcharlt/lp1131889_sort_cn_by_sortkey branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/gmcharlt/lp1131889_sort_cn_by_sortkey

I'm not putting a pullrequest tag on this yet in case there's any desire to discuss including call number affixes in the sort.

Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.4.0-beta
importance: Undecided → Wishlist
status: New → In Progress
assignee: nobody → Galen Charlton (gmc)
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-beta → 2.4.0-rc
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → 2.5.0-alpha
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m1 → none
milestone: none → 2.5.0-m2
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m2 → 2.5.0-alpha1
Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Revision history for this message
Galen Charlton (gmc) wrote :

Well, as there's evidently no desire to discuss this, I'm slapping a pullrequest on it.

The rebased patch can be found at the tip of collab/gmcharlt/lp1131889_sort_cn_by_sortkey_take2 in the working/Evergreen repository.

Changed in evergreen:
status: In Progress → New
tags: added: opac pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Pushed to master, thanks Galen!

Changed in evergreen:
status: New → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
assignee: Galen Charlton (gmc) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.