Acq: make behavior more consistent between manual and EDI invoices
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned | ||
2.3 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
For Evergreen 2.3+
This solves two problems.
1) With EDI invoices, we had been failing to disencumber fund debits
related to the invoiced lineitems, although that worked for manual
invoices.
2) With manual invoices, we would not automatically uncancel copies
when the user decided to invoice them despite their canceled status.
This was already working in EDI invoices though. This is especially
important since our schema lumps "backordered" in with "canceled,"
and in theory backordered things do show up eventually.
This looks a little bigger than it is. It mostly just moves code from one place to another. Tests well for me, but I am working with a site trying it out in a more realistic environment than I can rig up. Will therefore add pullrequest a little later. I'm also not trying to rush this into 2.3.4, so I'll wait a moment before setting a milestone.
Changed in evergreen: | |
status: | New → Triaged |
status: | Triaged → In Progress |
assignee: | nobody → Lebbeous Fogle-Weekley (lebbeous) |
milestone: | none → 2.4.0-beta |
Changed in evergreen: | |
milestone: | 2.4.0-beta → 2.4.0-rc |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
I have made some bug fixes for the EDI use case of this code (the manual invoice use case should have been, and should still be, fine). The branch has been squashed, rebased against current master, and force-pushed.
I'm still waiting on the results of some more testing before giving it the pullrequest tag, though.