Acq: make behavior more consistent between manual and EDI invoices

Bug #1131380 reported by Lebbeous Fogle-Weekley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.3
Fix Released
Undecided
Unassigned

Bug Description

For Evergreen 2.3+

    This solves two problems.

     1) With EDI invoices, we had been failing to disencumber fund debits
        related to the invoiced lineitems, although that worked for manual
        invoices.
     2) With manual invoices, we would not automatically uncancel copies
        when the user decided to invoice them despite their canceled status.
        This was already working in EDI invoices though. This is especially
        important since our schema lumps "backordered" in with "canceled,"
        and in theory backordered things do show up eventually.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/acq-edi-inv-disencumber-squash

This looks a little bigger than it is. It mostly just moves code from one place to another. Tests well for me, but I am working with a site trying it out in a more realistic environment than I can rig up. Will therefore add pullrequest a little later. I'm also not trying to rush this into 2.3.4, so I'll wait a moment before setting a milestone.

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

I have made some bug fixes for the EDI use case of this code (the manual invoice use case should have been, and should still be, fine). The branch has been squashed, rebased against current master, and force-pushed.

I'm still waiting on the results of some more testing before giving it the pullrequest tag, though.

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

More bug fixes to this bugfix are definitely coming.

Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
status: Triaged → In Progress
assignee: nobody → Lebbeous Fogle-Weekley (lebbeous)
milestone: none → 2.4.0-beta
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-beta → 2.4.0-rc
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

This (same branch, amended and force-pushed since last time) should be totally ready now: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/acq-edi-inv-disencumber-squash

tags: added: pullrequest
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

I missed that this bug was left in the "in progress" state. It really is ready to go.

Changed in evergreen:
status: In Progress → Triaged
assignee: Lebbeous Fogle-Weekley (lebbeous) → nobody
Revision history for this message
Mike Rylander (mrylander) wrote :

Let's get rid of as many EDI issues as we can as folks start using it more. Thanks, Lebbeous!

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
Revision history for this message
Bill Erickson (berick) wrote :

Code was backported before 2.3.11. Can't go back in time w/ milestones, so marking as fix committed for 2.3.12.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.