Reinstate pep version check in a run_pep8.sh file

[Steven Hardy]

sdake mentioned he would prefer our run_tests.sh to call a separate script to run the pep8 checks, instead of calling pep8 directly in run_tests.sh

This was during a discussion re bug 1131251, the fix for which removed the check for a specific pep8 version. It was mentioned that we could reinstate this test in a run_pep8.sh based on the contents of test-requires (so we can catch incorrect pep8 version when developers run tests not inside a venv, which was the purpose of the check removed from run_tests.sh to fix 1131251)

Seems like a good opportunity to add a hacking.py like nova too.

https://github.com/openstack/nova/blob/master/tools/run_pep8.sh

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23100

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23101

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23102

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23100
Committed: http://github.com/openstack/heat/commit/637740a4f1aa64e192c05638b76ad2355909e346
Submitter: Jenkins
Branch: master

commit 637740a4f1aa64e192c05638b76ad2355909e346
Author: Steven Dake <email address hidden>
Date: Wed Feb 27 10:26:46 2013 -0700

    Update infrastructure to more closely match other OpenStack projects

    This patch imports nova's HACKING.rst guidelines altered for Heat.
    This patch imports nova's run_pep8.sh with some minor alterations.
    This patch imports nova's hacking.py extensions to pep8.

    This patch places the run_pep8 logic in a separate file rather than
    having it spread between tox.ini and run_tests.sh. The HACKING.rst
    requirements as well as general pep8 requirements are then enforced
    with run_pep8.sh.

    Avoid running once the N802 rule until dependency changelogs are
    less then 50 characters.

    Change-Id: If46c14668eae3cf11b8fbff46d766cc589d701aa
    Fixes: Bug #1131275

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23101
Committed: http://github.com/openstack/heat/commit/eea4a6d16d274839a3da650a735a9b25f7072679
Submitter: Jenkins
Branch: master

commit eea4a6d16d274839a3da650a735a9b25f7072679
Author: Steven Dake <email address hidden>
Date: Wed Feb 27 10:39:54 2013 -0700

    Add heat-watch to pep8 checks

    heat-watch was missing from pep8 checks in the past. Tidy up heat-watch
    and add to run_pep8.sh.

    Change-Id: I36680b24ee90a5daeb7f8d7418b665a215026325
    Fixes: Bug #1131275

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23102
Committed: http://github.com/openstack/heat/commit/2358f6d5bc3e79f6d973ec25de81569286aeabc4
Submitter: Jenkins
Branch: master

commit 2358f6d5bc3e79f6d973ec25de81569286aeabc4
Author: Steven Dake <email address hidden>
Date: Wed Feb 27 11:00:32 2013 -0700

    Remove unused imports from repo in preperation for pyflakes

    Lots of unused imports

    Fixes: Bug #1131275

    Change-Id: Iacb1d02173b0ec0e0dc81aff84ca6e29e60e2934
    Signed-off-by: Steven Dake <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23125
Committed: http://github.com/openstack/heat/commit/d640718167eb9e9d17c97b64b636063f2b82ba1e
Submitter: Jenkins
Branch: master

commit d640718167eb9e9d17c97b64b636063f2b82ba1e
Author: Steven Dake <email address hidden>
Date: Wed Feb 27 15:23:48 2013 -0700

    Gate on certain pyflakes failures

    To prevent recent gating problems from typos, an
    import not used and redefinition of function problems in
    the source code have become gating.

    Fixes: Bug #1131275
    Change-Id: I7011f3ac5940afc70c38758e67a2222a66e625c3
    Signed-off-by: Steven Dake <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23233

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23235

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23235
Committed: http://github.com/openstack/heat/commit/bb65fee164900cdd7faedf2f9c244d518ee5082a
Submitter: Jenkins
Branch: master

commit bb65fee164900cdd7faedf2f9c244d518ee5082a
Author: Steven Dake <email address hidden>
Date: Thu Feb 28 17:15:26 2013 -0700

    Remove unused import from loguserdata.py

    Change-Id: I0bdf8a51e0d21533c5ce8148cdffcbc92f89fef9
    Fixes: Bug #1131275

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23436

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23436
Committed: http://github.com/openstack/heat/commit/7ffeadc54b61735881818ee1393145a7730fbe31
Submitter: Jenkins
Branch: master

commit 7ffeadc54b61735881818ee1393145a7730fbe31
Author: Steven Dake <email address hidden>
Date: Mon Mar 4 10:16:16 2013 -0700

    Remove unused import from test_nokey.py

    test_nokey.py was recently merged into the source tree with an
    unused import (copy.py).

    Change-Id: I27b7040b5719ea21d1e0a79afe499bf7fa5a94e5
    Fixes: Bug #1131275

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23233
Committed: http://github.com/openstack/heat/commit/78e975eaf142aca97a3976830e85ce1ed519528a
Submitter: Jenkins
Branch: master

commit 78e975eaf142aca97a3976830e85ce1ed519528a
Author: Steven Dake <email address hidden>
Date: Thu Feb 28 17:02:11 2013 -0700

    Add pyflakes to test-requires

    pyflakes needs to be installed in the venv

    Change-Id: Ie7aada13da4e191108363c80daf719212d06d316
    Fixes: Bug #1131275