"add interface" form in Admin Router Detail does not work

Bug #1131177 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Akihiro Motoki

Bug Description

When I clicked "add interface" button on the Admin Router Detail,
"Add Interface" Panel was not displayed and reported an error happens.

I found the following traceback.

[Thu Feb 21 11:56:08 2013] [error] ERROR:django.request:Internal Server Error: /admin/routers/8300ad5d-89ed-46ed-bdd7-6bb0a21f2d74/addinterface
[Thu Feb 21 11:56:08 2013] [error] Traceback (most recent call last):
[Thu Feb 21 11:56:08 2013] [error] File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 136, in get_response
[Thu Feb 21 11:56:08 2013] [error] response = response.render()
[Thu Feb 21 11:56:08 2013] [error] File "/usr/local/lib/python2.7/dist-packages/django/template/response.py", line 104, in render
[Thu Feb 21 11:56:08 2013] [error] self._set_content(self.rendered_content)
[Thu Feb 21 11:56:08 2013] [error] File "/usr/local/lib/python2.7/dist-packages/django/template/response.py", line 79, in rendered_content
[Thu Feb 21 11:56:08 2013] [error] template = self.resolve_template(self.template_name)
[Thu Feb 21 11:56:08 2013] [error] File "/usr/local/lib/python2.7/dist-packages/django/template/response.py", line 57, in resolve_template
[Thu Feb 21 11:56:08 2013] [error] return loader.get_template(template)
[Thu Feb 21 11:56:08 2013] [error] File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py", line 145, in get_template
[Thu Feb 21 11:56:08 2013] [error] template, origin = find_template(template_name)
[Thu Feb 21 11:56:08 2013] [error] File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py", line 138, in find_template
[Thu Feb 21 11:56:08 2013] [error] raise TemplateDoesNotExist(name)
[Thu Feb 21 11:56:08 2013] [error] TemplateDoesNotExist: admin/routers/ports/_create.html

Tags: quantum
Akihiro Motoki (amotoki)
Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22547

Changed in horizon:
status: New → In Progress
Revision history for this message
Akihiro Motoki (amotoki) wrote : Re: Cannot display "add interface" form in Admin Router Detail

I found it is not sufficient just to change the template to project/routers/ports/create.html.
Since project/routers/ports/create.html contains a form link to project panel instead of admin panel, we needs to prepare templates for admin panel. I will update the patch.

summary: - Cannot display "add interface" form in Admin Router Detail
+ "add interface" form in Admin Router Detail does not work
Changed in horizon:
milestone: none → grizzly-rc1
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/22547
Committed: http://github.com/openstack/horizon/commit/0e542cb0e8574a2fa7ff7028e16c7a8259586739
Submitter: Jenkins
Branch: master

commit 0e542cb0e8574a2fa7ff7028e16c7a8259586739
Author: Akihiro MOTOKI <email address hidden>
Date: Thu Feb 21 21:04:52 2013 +0900

    Ensure "Add Interface" form in Admin Panel works

    This commit add new templates for interface add/delete operations
    in admin panel to make sure the original page is displayed after
    adding a router interface successfully.

    It also changes the following:
    - Update the help message in "Add Interface" and "Set Gateway" forms
      (both in project and admin panels)
    - Fixes a issue that Project router detail was displayed after setting
      an external gateway to a router in admin panel.
      Admin router detail is expected to display
    - Make sure a router name is displayed in router detail in admin panel.

    Fixes Bug #1131177

    Change-Id: I9728cb68972977f868549b61979d9c779cd9fd4e

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.