fails to get version from git repo

Bug #1131162 reported by Isaku Yamahata
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
neutron
Invalid
High
Isaku Yamahata
oslo-incubator
Fix Released
High
Isaku Yamahata
Grizzly
Fix Released
High
Isaku Yamahata

Bug Description

quantum run_tests.py fails because openstack.common.setup._get_version_from_git fails.
It is because quantum unit tests run under quantum/tests/unit instead of git root dir.
So the function should check parent dirs for .git.

ERROR: test_network_gateway_update (quantum.tests.unit.nicira.test_networkgw.NetworkGatewayExtensionTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "quantum/quantum/tests/unit/nicira/test_networkgw.py", line 70, in setUp
    config.parse(args=args)
  File "quantum/quantum/common/config.py", line 99, in parse
    version='%%prog %s' % quantum_version.release_string())
  File "quantum/quantum/openstack/common/version.py", line 63, in release_string
    self.release = self._get_version_from_pkg_resources()
  File "quantum/quantum/openstack/common/version.py", line 56, in _get_version_from_pkg_resources
    return setup.get_version(self.package)
  File "quantum/quantum/openstack/common/setup.py", line 334, in get_version
    raise Exception("Versioning for this project requires either an sdist"
Exception: Versioning for this project requires either an sdist tarball, or access to an upstream git repository.

Revision history for this message
Isaku Yamahata (yamahata) wrote :

The patch for oslo is available at
https://review.openstack.org/#/c/22534/

Revision history for this message
Isaku Yamahata (yamahata) wrote :

The above patch is abondaned and the issue is being addressed by
https://review.openstack.org/#/c/22181/

Revision history for this message
Sumit Naiksatam (snaiksat) wrote :

Both reviews seem to be abandoned?

Changed in quantum:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22578

Changed in quantum:
status: Confirmed → In Progress
Changed in quantum:
assignee: nobody → Arvind Somya (asomya)
milestone: none → grizzly-rc1
Arvind Somya (asomya)
Changed in quantum:
assignee: Arvind Somya (asomya) → Isaku Yamahata (yamahata)
Revision history for this message
Gary Kotton (garyk) wrote :

The latest common code has been added.

Changed in quantum:
status: In Progress → Invalid
dan wendlandt (danwent)
Changed in quantum:
milestone: grizzly-rc1 → none
Mark McLoughlin (markmc)
Changed in oslo:
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Isaku Yamahata (yamahata)
Mark McLoughlin (markmc)
Changed in oslo:
milestone: none → grizzly-rc1
Thierry Carrez (ttx)
Changed in oslo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.