duplicate spawn code in the PowerVM driver

Bug #1130680 reported by Lance Bragstad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Lance Bragstad

Bug Description

Because of a rebasing issue, duplicate code was created in the PowerVM driver. This code needs to be refactored so that only one private method _create_lpar_instance() exists in /powervm/driver.py. This was introduced in the addition of resize/migrate functionality. This doesn't effect the performance of the functionality but it is unnecessary to have extra lines if they never execute.

Changed in nova:
assignee: nobody → Lance Bragstad (ldbragst)
Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/22243
Committed: http://github.com/openstack/nova/commit/2793f174b497b4aacf09b255380c90616518dc5f
Submitter: Jenkins
Branch: master

commit 2793f174b497b4aacf09b255380c90616518dc5f
Author: Lance Bragstad <email address hidden>
Date: Mon Feb 18 19:32:23 2013 +0000

    Removed duplicate spawn code in PowerVM driver

    After introducing resize/migrate in PowerVM there was
    some code that was duplicated after a rebase. The commit
    removes the duplicate code. The functionality of
    resize/migrate remains the same as introducted in
    Change I72345626

    Bug #1130680

    Change-Id: I1fe3d8e1f2a19fd40a03c8c38d90c01711356b38

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.