Mir

Exception when exiting client

Bug #1130259 reported by Bryce Harrington
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Undecided
Alan Griffiths
Mir 0.0.3

Bug Description

Ran server in one ssh session (under gdb). Executed client (mir_demo_client_accelerated) in a second ssh session, let it run a bit, and then exited it with ^C.

The server session showed this error:

ERROR: Throw location unknown (consider using BOOST_THROW_EXCEPTION)
Dynamic exception type: boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::system::system_error> >
std::exception::what: write: Broken pipe

This is with the current staging packages.

Related branches

lp:~alan-griffiths/mir/fix-bug-1130259
Robert Ancell: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 842 lines (+387/-77)
17 files modified
include/server/mir/default_server_configuration.h (+3/-0)
include/server/mir/frontend/message_processor_report.h (+53/-0)
include/server/mir/frontend/null_message_processor_report.h (+43/-0)
include/server/mir/frontend/protobuf_ipc_factory.h (+2/-0)
include/server/mir/logging/message_processor_report.h (+53/-0)
include/test/mir_test_doubles/stub_ipc_factory.h (+6/-0)
src/server/default_server_configuration.cpp (+35/-4)
src/server/frontend/CMakeLists.txt (+1/-0)
src/server/frontend/binder_service.cpp (+10/-4)
src/server/frontend/null_message_processor_report.cpp (+41/-0)
src/server/frontend/protobuf_message_processor.cpp (+37/-16)
src/server/frontend/protobuf_message_processor.h (+7/-1)
src/server/frontend/protobuf_socket_communicator.cpp (+2/-1)
src/server/logging/CMakeLists.txt (+1/-0)
src/server/logging/message_processor_report.cpp (+75/-0)
src/server/logging/session_mediator_report.cpp (+1/-1)
tests/integration-tests/test_error_reporting.cpp (+17/-50)
Bryce Harrington (bryce)
summary: - Exception when ^C client
+ Exception when exiting client
Daniel van Vugt (vanvugt)
information type: Proprietary → Public
Revision history for this message
Kevin DuBois (kdub) wrote :

The problem that is happening is the client is disconnected while IPC is happening (eg, the other end of the fd is dying)
This generates an exception ( which is caught and handled) I guess 'invalid' is the proper state for this bug?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Clients can and will disconnect uncleanly all the time, in reality. It is common. We should consider not logging it as an error.

Changed in mir:
status: New → Confirmed
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Agreed. An "error" should be something that prevents the server doing its job.

Alan Griffiths (alan-griffiths)
Changed in mir:
assignee: nobody → Alan Griffiths (alan-griffiths)
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Confirmed → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.0.3
Robert Ancell (robert-ancell)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.