ComputeManager running_deleted_instances doesn't support instance uuids

Bug #1129519 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Hans Lindgren

Bug Description

ComputeManager _get_instances_on_driver() first tries driver.list_instance_uuids(), and if that is not implemented, falls back to driver.list_instances() to get a list of names. However, _running_deleted_instances() simply calls driver.list_instances(). Instead, it should try the newer list_instance_uuids() method first.

Tags: baremetal
Revision history for this message
Robert Collins (lifeless) wrote :

This makes baremetal have to have a arbitrary string column in the driver for no reason, so its baremetal affecting (but not solely).

tags: added: baremetal
Changed in nova:
status: New → Triaged
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22480

Changed in nova:
assignee: nobody → Hans Lindgren (hanlind)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/23047

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/23047
Committed: http://github.com/openstack/nova/commit/e03a3df8869ad5303aaba0f006c17d0927fa6dab
Submitter: Jenkins
Branch: master

commit e03a3df8869ad5303aaba0f006c17d0927fa6dab
Author: Hans Lindgren <email address hidden>
Date: Wed Feb 27 00:08:44 2013 +0100

    Refactor compute manager _get_instances_by_driver

    Make the method more efficient by only querying nova-conductor
    once. Also limit fallback instance query to host only. This is
    in preparation for fixing bug 1129519.

    Change-Id: I7de14f1ffda37c14f760f602fd81250d2163b430

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/22480
Committed: http://github.com/openstack/nova/commit/58889a08fcce7407366f8aae0c703b4fa0480725
Submitter: Jenkins
Branch: master

commit 58889a08fcce7407366f8aae0c703b4fa0480725
Author: Hans Lindgren <email address hidden>
Date: Wed Feb 27 00:23:47 2013 +0100

    Make ComputeManager _running_deleted_instances query by uuid

    Reuse existing _get_instances_on_driver method to query driver for
    running instances.

    Resolves bug 1129519.

    Change-Id: I9186b289fadfc4414874b3ba52195e9acfac18b4

Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.