all hook tools should support --format
Bug #1129130 reported by
Roger Peppe
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-core |
Fix Released
|
High
|
Tim Penhey | ||
Bug Description
Some charms assume they can pass --format=json to hook tools that
don't currently understand it (relation-set being one example).
We should support --format on all hook tools that the python version
supports it on.
Related branches
lp:~thumper/juju-core/format-flag
- Juju Engineering: Pending requested
-
Diff: 250 lines (+98/-22)7 files modifiedtesting/cmd.go (+12/-0)
worker/uniter/jujuc/juju-log.go (+12/-5)
worker/uniter/jujuc/juju-log_test.go (+21/-11)
worker/uniter/jujuc/ports.go (+11/-6)
worker/uniter/jujuc/ports_test.go (+23/-0)
worker/uniter/jujuc/relation-set.go (+6/-0)
worker/uniter/jujuc/relation-set_test.go (+13/-0)
Revision history for this message
| William Reade (fwereade) wrote | #1 |
| Changed in juju-core: | |
| importance: | Undecided → High |
| Changed in juju-core: | |
| assignee: | nobody → Tim Penhey (thumper) |
| status: | New → Triaged |
| Changed in juju-core: | |
| status: | Triaged → Confirmed |
| Changed in juju-core: | |
| status: | Confirmed → Triaged |
| Changed in juju-core: | |
| status: | Triaged → In Progress |
| milestone: | none → 1.9.12 |
Revision history for this message
| Patrick Hetu (patrick-hetu) wrote | #2 |
| Changed in juju-core: | |
| status: | In Progress → Fix Committed |
| Changed in juju-core: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
IMO we should only "support" it in that we don't fail -- it should be ignored and generate a deprecation warning (so that maybe, one day, we can accept input in multiple formats).