isnan() not declared on macosx
Bug #1128419 reported by
Daniel Schürmann
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Undecided
|
RJ Skerry-Ryan | ||
Bug Description
Our build server has failed building daschuers_trunk because of:
src/engine/
I have fixed it with the attached patch.
I hope one can explain why this is required and if this is required for trunk as well.
You can find many reports on the web complaining about isnan() and macosx.
Related branches
Revision history for this message
| Daniel Schürmann (daschuer) wrote | #1 |
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #2 |
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #3 |
| Changed in mixxx: | |
| status: | New → Fix Committed |
| assignee: | nobody → RJ Ryan (rryan) |
| milestone: | none → 1.11.0 |
| status: | Fix Committed → Fix Released |
| status: | Fix Released → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #4 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
I'm quite confused by this too. I've put a fix in lp:mixxx/1.11 r3836 which replaces how isnan() is dealt with across the whole codebase. The standard thing to do when using isnan() should be to include mathstuff.h now instead of copying that snippet around.