Desk renewal use original circ library

Bug #1125644 reported by Ben Shum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen master

Similar to how there's already a global flag for reusing the original circulating library for OPAC renewals (see bug 806049), create another flag for doing the same with desk renewals.

Use case:

Patron checks out material at Library A, renews at Library B, the circulation changes to following the circ policies set by Library B instead of A. Which could be a problem if B charges fines while A does not. Since we have the flag for OPAC renewals set to follow original circ lib, if they had made the same renewal action at home, they wouldn't have gotten different circ policies affecting their previous circs.

Working branch: working/user/bshum/desk_renewal_reuse_circ_lib

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/desk_renewal_reuse_circ_lib

Tags: pullrequest
Ben Shum (bshum)
Changed in evergreen:
importance: Undecided → Wishlist
milestone: none → 2.4.0-alpha
tags: added: pullrequest
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-alpha1 → 2.4.0-beta
Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-beta → 2.4.0-rc
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → 2.5.0-alpha
Revision history for this message
Ben Shum (bshum) wrote :

A new thought I had was whether this change should just be extended to make a single global flag to define whether any renewal reuses the original circ library vs. having multiple flags for each type of renewal.

Does anyone have a use case where each type of renewal would have to be decided to use the original circ library or not?

Revision history for this message
Michele Morgan (mmorgan) wrote :

We would want these separate for statistical purposes. We don't have the issue of circulation policies changing, because our policies are set such that the item's owning library determines the rules.

For a desk renewal, if a patron walked into Library B to renew when they had originally checked out the item at Library A, we would want to give Library B a circ stat so they get credit for serving that patron. If the patron renewed online, the credit goes to the original circulating library.

Revision history for this message
Ben Shum (bshum) wrote :

Aha, good to know this particular scenario. Thanks Michele!

In that case, I'll let the code stand as is for this ticket and allow for libraries to choose whether to affect behavior differently for just desk renewals and deal with the consequences of statistics on their own. For our use case, it seems we're still more interested in controlling the circulation behavior for desk renewals.

Revision history for this message
Ben Shum (bshum) wrote :

Freshly rebased to latest master and included new short release note as well.

Changed in evergreen:
assignee: nobody → Mike Rylander (mrylander)
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m1 → 2.5.0-m2
Revision history for this message
Mike Rylander (mrylander) wrote :

Pushed to master. Thanks, Ben! Sorry for the delay.

Changed in evergreen:
status: Triaged → Fix Committed
assignee: Mike Rylander (mrylander) → nobody
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.