nova leaves stale .part files on disk when downloading non raw VM images

Bug #1125068 reported by Pádraig Brady
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Pádraig Brady
Folsom
Fix Released
Medium
Pádraig Brady

Bug Description

With force_raw_images=true (the default), when libvirt downloads a non raw image,
it will leave the redundant .part file on disk

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21955

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/21956

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/21955
Committed: http://github.com/openstack/nova/commit/1501a4e4f75efb63385a1dadc728c2ef245bf7de
Submitter: Jenkins
Branch: master

commit 1501a4e4f75efb63385a1dadc728c2ef245bf7de
Author: Pádraig Brady <email address hidden>
Date: Thu Feb 14 10:37:21 2013 +0000

    remove intermediate libvirt downloaded images

    * nova/virt/images.py (fetch_to_raw): When converting a downloaded
    image to raw, ensure we delete the original download image.
    I.E. the .part file. The regression was introduced in 7c265343.
    * nova/tests/test_libvirt.py (test_fetch_raw_image): A new test
    for this function which wasn't tested previously.

    Fixes bug: 1125068
    Change-Id: Ie6f2cff1a554b8500fd66f0832566ae1b317be40

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/folsom)

Reviewed: https://review.openstack.org/21956
Committed: http://github.com/openstack/nova/commit/889e9c0be4852fa4b96bdceba889f9584ac3b716
Submitter: Jenkins
Branch: stable/folsom

commit 889e9c0be4852fa4b96bdceba889f9584ac3b716
Author: Pádraig Brady <email address hidden>
Date: Thu Feb 14 10:37:21 2013 +0000

    remove intermediate libvirt downloaded images

    * nova/virt/images.py (fetch_to_raw): When converting a downloaded
    image to raw, ensure we delete the original download image.
    I.E. the .part file. The regression was introduced in 7c265343.
    * nova/tests/test_libvirt.py (test_fetch_raw_image): A new test
    for this function which wasn't tested previously.

    Conflicts:

     nova/tests/test_libvirt.py
     nova/virt/images.py

    Fixes bug: 1125068
    Change-Id: Ie6f2cff1a554b8500fd66f0832566ae1b317be40
    (cherry picked from commit 1501a4e4f75efb63385a1dadc728c2ef245bf7de)

Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.