raring: tuxguitar doesn't start due to erroneous startup script

[Steve Markgraf]

When running tuxguitar in 13.04, I get the following error:
/usr/bin/tuxguitar: 138: /usr/bin/tuxguitar: Syntax error: end of file unexpected (expecting "}")

Adding a '}' in line 98 of /usr/bin/tuxguitar fixed the problem, see the attached patch.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "0001-tuxguitar.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Sasa Paporovic (melchiaros)]

[with patch]

Hi Toni, Hi Phillip,

I have found you on the maintainer list for Debian tuxguitar.

I guess this this problme here might also affect tuxguitar on Debian.

steve-m was so keen to create a patch for this problem.

[gregor herrmann (gregoa)]

On Tue, 12 Feb 2013 20:10:03 -0000, Steve M. wrote:

> When running tuxguitar in 13.04, I get the following error:
> /usr/bin/tuxguitar: 138: /usr/bin/tuxguitar: Syntax error: end of file unexpected (expecting "}")
>
> Adding a '}' in line 98 of /usr/bin/tuxguitar fixed the problem, see the
> attached patch.

FWIW: The packages in Debian and Ubuntu are different, Debian has
1.2-13 in testing and unstable, Ubuntu has 1.2-13ubuntu1 in raring.

The diff can be seen here:
https://patches.ubuntu.com/t/tuxguitar/tuxguitar_1.2-13ubuntu1.patch

It looks like the patch (debian/patches/04-no-mozilla.patch) removes a '}' too much somewhere ...

(And tuxguitar also starts fine on Debian unstable. Although from
looking at the script there seems to be an excess '}' in line 140?)

Maybe having only one shell script for both Debian and Ubuntu
(skipping the Mozilla check when running on Ubuntu) would be easier?
(Using dpkg-vendor etc.)

Cheers,
gregor

--
 .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `- NP: Carole King: Carry Your Load

[Micah Gersten (micahg)]

Sorry, I'll fix this later today. Thanks for reporting it.

[Micah Gersten (micahg)]

As for the idea of using dpkg-vendor, we can't use that in the shell script since it's not guaranteed to be installed (it's in build essential). I'd be up for patching the script to be conditionally set at build time with a substitution variable to check for mozilla or not.

[gregor herrmann (gregoa)]

On Wed, 06 Mar 2013 05:49:34 -0000, Micah Gersten wrote:

> As for the idea of using dpkg-vendor, we can't use that in the shell
> script since it's not guaranteed to be installed (it's in build
> essential). I'd be up for patching the script to be conditionally set
> at build time with a substitution variable to check for mozilla or not.

Good point, sorry for missing this.

I've now prepared a quick patch to adjust the dependencies and the
shell script during build; the former part should be ok, the latter
is probably a bit fragile ...

Attaching it here for review; of course it would need to go into
Debian eventually.

I've tested the build in sid and raring chroots.

Cheers,
gregor

--
 .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `- NP: J.J. Cale: Don't Wait

[Philippe Coval (rzr)]

You can try to upload to debian too since it's under co-maintenance now

[Micah Gersten (micahg)]

@gregor
The patch looks great and seems to work fine. I'd be happy to sync the package once it's uploaded to Debian. Thanks!

[gregor herrmann (gregoa)]

On Sun, 10 Mar 2013 19:08:49 -0000, Philippe Coval wrote:

> You can try to upload to debian too since it's under co-maintenance now

Thanks!
I wouldn't upload an invasive patch like this without maintainer
consent, but I've you reviewed it and are ok with it, I'm happy tp go
ahead. (And tag and push to collab-maint.)

On Sun, 10 Mar 2013 20:17:16 -0000, Micah Gersten wrote:

> @gregor
> The patch looks great and seems to work fine.

Cool, thanks for checking.

> I'd be happy to sync
> the package once it's uploaded to Debian. Thanks!

I'd need to upload it to experimental as long as Debian is in the
wheezy freeze, but AFAIK Ubuntu can also sync from experimental,
right?

So let's wait if Philippe is ok with this approach.

Cheers,
gregor

--
 .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `- NP: Die Schmetterlinge: Sturmzeit

[Philippe Coval (rzr)]

On 03/12/2013 06:08 PM, gregor herrmann wrote:
> On Sun, 10 Mar 2013 19:08:49 -0000, Philippe Coval wrote:
>
>> You can try to upload to debian too since it's under co-maintenance
> now
>
> Thanks!

I give you white card ...

feel free to join the java team , I am sure there are tips to be shared

regards and thank you for your contribution

--
http://rzr.free.fr gpg:0x467094BC mailto:<email address hidden> xmpp:<email address hidden>

[Micah Gersten (micahg)]

Syncing from experimental is fine, thanks. Also, thanks to Philippe for being open to the changes.

[gregor herrmann (gregoa)]

On Tue, 12 Mar 2013 18:15:30 -0000, Philippe Coval wrote:

> >> You can try to upload to debian too since it's under co-maintenance
> >> now
> > Thanks!
> I give you white card ...

Merci !

> feel free to join the java team , I am sure there are tips to be shared

I'm alrady a member :)

Ok, I've uploaded tuxguitar to experimental now, and pushed the
changes to pkg-java/tuxguitar.git (I hope that's the right repo,
there's also one under collab-maint ...).

Cheers,
gregor

--
 .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `- NP: Arlo Guthrie: Coming into LA

[Tony Mancill (tmancill)]

On 03/12/2013 01:23 PM, gregor herrmann wrote:
> On Tue, 12 Mar 2013 18:15:30 -0000, Philippe Coval wrote:
>
>>>> You can try to upload to debian too since it's under co-maintenance
>>>> now
>>> Thanks!
>> I give you white card ...
>
> Merci !
>
>> feel free to join the java team , I am sure there are tips to be shared
>
> I'm alrady a member :)
>
> Ok, I've uploaded tuxguitar to experimental now, and pushed the
> changes to pkg-java/tuxguitar.git (I hope that's the right repo,
> there's also one under collab-maint ...).

Hi Gregor,

Thanks for the upload! Just to verify, pkg-java/tuxguitar.git is the
correct repo.

I looked but couldn't find the tuxguitar under collab-maint but didn't
see one. Perhaps you cleaned it up already?

Cheers,
tony

[Philippe Coval (rzr)]

On 03/13/2013 05:42 AM, Tony Mancill wrote:
> On 03/12/2013 01:23 PM, gregor herrmann wrote:
>> On Tue, 12 Mar 2013 18:15:30 -0000, Philippe Coval wrote:
>>
>>>>> You can try to upload to debian too since it's under co-maintenance
>>>>> now
>>>> Thanks!
>>> I give you white card ...
>>
>> Merci !
>>
>>> feel free to join the java team , I am sure there are tips to be shared
>>
>> I'm alrady a member :)
>>
>> Ok, I've uploaded tuxguitar to experimental now, and pushed the
>> changes to pkg-java/tuxguitar.git (I hope that's the right repo,
>> there's also one under collab-maint ...).

never used that 2d one just the pkg-java git

>
> Hi Gregor,
>
> Thanks for the upload! Just to verify, pkg-java/tuxguitar.git is the
> correct repo.
>
> I looked but couldn't find the tuxguitar under collab-maint but didn't
> see one. Perhaps you cleaned it up already?

maybe we can del c-m one

thx tony

--
http://rzr.free.fr gpg:0x467094BC mailto:<email address hidden> xmpp:<email address hidden>

[Micah Gersten (micahg)]

Hrm, didn't realize that the changelog was missing # (should be LP: #XXXXXX), no worries though, manually closing, thanks to the awesome Debian maintainers for getting this fixed

tuxguitar (1.2-14) experimental; urgency=low

  * Team upload.

  [ Philippe Coval ]
  * Supports also jack2 (Closes: #608041)
  * fix: maintainers email

  [ gregor herrmann ]
  * Make Ubuntu diff obsolete:
    - debian/{control,rules}: don't insert xulrunner dependency on Ubuntu and
      derivatives
    - debian/rules: remove mozilla check from tuxguitar.sh during build on
      Ubuntu and derivates (LP: 1123416)
  * Set Standards-Version to 3.9.4 (no changes).
  * Remove build dependency on quilt (not needed with source format '3.0
    (quilt)').
  * Remove duplicated sections from binary packages in debian/control.

[gregor herrmann (gregoa)]

On Wed, 13 Mar 2013 16:21:03 -0000, Micah Gersten wrote:

> Hrm, didn't realize that the changelog was missing # (should be LP:
> #XXXXXX), no worries though, manually closing, thanks to the awesome
> Debian maintainers for getting this fixed

> - debian/rules: remove mozilla check from tuxguitar.sh during build on
> Ubuntu and derivates (LP: 1123416)

Oops, sorry for missing the '#', and thanks for manually handling it.

Cheers,
gregor

--
 .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `- NP: Anouar Brahem: De tout ton coeur