innobackupex fails when --no-lock and --rsync are used in conjunction

[markus_albe]

This command line will fail:
innobackupex --defaults-file=/home/kolita/sandboxes/msb_5_5_18/my.sandbox.cnf --rsync --no-lock /tmp

kolita@lilith:~$ xtrabackup --version
xtrabackup version 2.0.5 for Percona Server 5.1.59 unknown-linux-gnu (x86_64) (revision id: undefined)

kolita@lilith:~$ innobackupex --defaults-file=/home/kolita/sandboxes/msb_5_5_18/my.sandbox.cnf --rsync --no-lock /tmp

InnoDB Backup Utility v1.5.1-xtrabackup; Copyright 2003, 2009 Innobase Oy
and Percona Ireland Ltd 2009-2012. All Rights Reserved.

This software is published under
the GNU GENERAL PUBLIC LICENSE Version 2, June 1991.

130212 16:37:51 innobackupex: Starting mysql with options: --defaults-file='/home/kolita/sandboxes/msb_5_5_18/my.sandbox.cnf' --unbuffered --
130212 16:37:51 innobackupex: Connected to database with mysql child process (pid=6470)
130212 16:37:57 innobackupex: Connection to database server closed
IMPORTANT: Please check that the backup run completes successfully.
           At the end of a successful backup run innobackupex
           prints "completed OK!".

innobackupex: Using mysql Ver 14.14 Distrib 5.5.29, for debian-linux-gnu (x86_64) using readline 6.2
innobackupex: Using mysql server version Copyright (c) 2000, 2012, Oracle and/or its affiliates. All rights reserved.

innobackupex: Created backup directory /tmp/2013-02-12_16-37-57
130212 16:37:57 innobackupex: Starting mysql with options: --defaults-file='/home/kolita/sandboxes/msb_5_5_18/my.sandbox.cnf' --unbuffered --
130212 16:37:57 innobackupex: Connected to database with mysql child process (pid=6498)
130212 16:37:59 innobackupex: Connection to database server closed

130212 16:37:59 innobackupex: Starting ibbackup with command: xtrabackup_55 --defaults-file="/home/kolita/sandboxes/msb_5_5_18/my.sandbox.cnf" --defaults-group="mysqld" --backup --suspend-at-end --target-dir=/tmp/2013-02-12_16-37-57
innobackupex: Waiting for ibbackup (pid=6506) to suspend
innobackupex: Suspend file '/tmp/2013-02-12_16-37-57/xtrabackup_suspended'

xtrabackup_55 version 2.0.5 for Percona Server 5.5.16 Linux (x86_64) (revision id: undefined)
xtrabackup: uses posix_fadvise().
xtrabackup: cd to /home/kolita/sandboxes/msb_5_5_18/data
xtrabackup: Target instance is assumed as followings.
xtrabackup: innodb_data_home_dir = ./
xtrabackup: innodb_data_file_path = ibdata1:10M:autoextend
xtrabackup: innodb_log_group_home_dir = /home/kolita/sandboxes/msb_5_5_18/iblogs
xtrabackup: innodb_log_files_in_group = 2
xtrabackup: innodb_log_file_size = 134217728
xtrabackup: using O_DIRECT
130212 16:37:59 InnoDB: Warning: allocated tablespace 28, old maximum was 9
>> log scanned up to (13418540430)
[01] Copying ./ibdata1 to /tmp/2013-02-12_16-37-57/ibdata1
>> log scanned up to (13418540430)
[01] ...done
[01] ./test/my_distributors_warehouses_products.ibd is compressed with page size = 8192 bytes
[01] Copying ./test/my_distributors_warehouses_products.ibd to /tmp/2013-02-12_16-37-57/./test/my_distributors_warehouses_products.ibd
[01] ...done
[01] Copying ./test/dt.ibd to /tmp/2013-02-12_16-37-57/./test/dt.ibd
[01] ...done
[01] Copying ./test/i28581.ibd to /tmp/2013-02-12_16-37-57/./test/i28581.ibd
[01] ...done
[01] Copying ./test/t.ibd to /tmp/2013-02-12_16-37-57/./test/t.ibd
[01] ...done
[01] Copying ./test/t1.ibd to /tmp/2013-02-12_16-37-57/./test/t1.ibd
[01] ...done
[01] Copying ./test/b.ibd to /tmp/2013-02-12_16-37-57/./test/b.ibd
[01] ...done
[01] Copying ./test/c.ibd to /tmp/2013-02-12_16-37-57/./test/c.ibd
[01] ...done
[01] Copying ./sbtest/sbtest1.ibd to /tmp/2013-02-12_16-37-57/./sbtest/sbtest1.ibd
>> log scanned up to (13418540430)
[01] ...done
[01] Copying ./sbtest/sbtest4.ibd to /tmp/2013-02-12_16-37-57/./sbtest/sbtest4.ibd
[01] ...done
[01] Copying ./sbtest/sbtest2.ibd to /tmp/2013-02-12_16-37-57/./sbtest/sbtest2.ibd
[01] ...done
>> log scanned up to (13418540430)
[01] Copying ./sbtest/sbtest3.ibd to /tmp/2013-02-12_16-37-57/./sbtest/sbtest3.ibd
[01] ...done
[01] Copying ./world/Country.ibd to /tmp/2013-02-12_16-37-57/./world/Country.ibd
[01] ...done
[01] Copying ./world/CountryLanguage.ibd to /tmp/2013-02-12_16-37-57/./world/CountryLanguage.ibd
[01] ...done
[01] Copying ./world/City.ibd to /tmp/2013-02-12_16-37-57/./world/City.ibd
[01] ...done
[01] Copying ./percona/a.ibd to /tmp/2013-02-12_16-37-57/./percona/a.ibd
[01] ...done
[01] Copying ./employees/titles.ibd to /tmp/2013-02-12_16-37-57/./employees/titles.ibd
[01] ...done
[01] Copying ./employees/departments.ibd to /tmp/2013-02-12_16-37-57/./employees/departments.ibd
[01] ...done
[01] Copying ./employees/salaries.ibd to /tmp/2013-02-12_16-37-57/./employees/salaries.ibd
>> log scanned up to (13418540430)
[01] ...done
[01] Copying ./employees/dept_manager.ibd to /tmp/2013-02-12_16-37-57/./employees/dept_manager.ibd
[01] ...done
[01] Copying ./employees/employees.ibd to /tmp/2013-02-12_16-37-57/./employees/employees.ibd
[01] ...done
[01] Copying ./employees/dept_emp.ibd to /tmp/2013-02-12_16-37-57/./employees/dept_emp.ibd
[01] ...done
>> log scanned up to (13418540430)

130212 16:38:25 innobackupex: Continuing after ibbackup has suspended
130212 16:38:25 innobackupex: Starting mysql with options: --defaults-file='/home/kolita/sandboxes/msb_5_5_18/my.sandbox.cnf' --unbuffered --
130212 16:38:25 innobackupex: Connected to database with mysql child process (pid=6535)

130212 16:38:27 innobackupex: Starting to backup non-InnoDB tables and files
innobackupex: in subdirectories of '/home/kolita/sandboxes/msb_5_5_18/data'
innobackupex: Backing up files '/home/kolita/sandboxes/msb_5_5_18/data/performance_schema/*.{frm,MYD,MYI,MAD,MAI,MRG,TRG,TRN,ARM,ARZ,CSM,CSV,opt,par}' (18 files)
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/charset_test2/db.opt'
innobackupex: Backing up files '/home/kolita/sandboxes/msb_5_5_18/data/test/*.{frm,MYD,MYI,MAD,MAI,MRG,TRG,TRN,ARM,ARZ,CSM,CSV,opt,par}' (15 files)
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/charset_test/db.opt'
innobackupex: Backing up files '/home/kolita/sandboxes/msb_5_5_18/data/mysql/*.{frm,MYD,MYI,MAD,MAI,MRG,TRG,TRN,ARM,ARZ,CSM,CSV,opt,par}' (72 files)
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/sbtest/sbtest4.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/sbtest/db.opt'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/sbtest/sbtest3.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/sbtest/sbtest1.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/sbtest/sbtest2.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/world/Country.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/world/CountryLanguage.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/world/db.opt'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/world/City.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/world/c2.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/percona/db.opt'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/percona/a.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/empty_schema/db.opt'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/employees/titles.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/employees/dept_emp.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/employees/employees.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/employees/db.opt'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/employees/dept_manager.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/employees/departments.frm'
innobackupex: Backing up file '/home/kolita/sandboxes/msb_5_5_18/data/employees/salaries.frm'

# Here it does the second pass directly

130212 16:38:27 Starting rsync as: rsync -t "/home/kolita/sandboxes/msb_5_5_18/data" --files-from="/home/kolita/sandboxes/msb_5_5_18/tmp/xtrabackup_rsyncfiles_pass2" "/tmp/2013-02-12_16-37-57"
130212 16:38:27 rsync finished successfully.

# and when it tries to perform the cleanup of the first stage it fails because the file isn't there... seems there's no prep when --no-lock?

innobackupex: Error: Can't open /home/kolita/sandboxes/msb_5_5_18/tmp/xtrabackup_rsyncfiles_pass1 for reading: No such file or directory
kolita@lilith:~$ >> log scanned up to (13418540430)

[Alexey Kopytov (akopytov)]

Right, there's no prep copy with --no-lock, we should just not attempt to delete the prep file list in this case.

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-24