libmir-server needs API for initializing server instance

[Robert Carr]

Currently we have some code in main.cpp related to initializing the mir instance (setting required signal handlers, parsing options, etc...).

In order to enable shells to utilize libmir-server in a uniform way, we should probably provide some API like:

mir::DisplayServerInstance::DisplayServerInstance(mir::ServerConfiguration)
mir::DisplayServerInstance::run(int argc, char **argv, std::function<void(mir::DisplayServer *)> server_ready)

[Robert Carr (robertcarr)]

The qt-poc branch contains a DisplayServerInstance class and example usage in src/main.cpp and src/demo-shell/demo_shell_main.cpp .

[Alan Griffiths (alan-griffiths)]

Rather than adding:

class mir::DisplayServerInstance and
mir::DisplayServerInstance::run(int argc, char **argv, std::function<void(mir::DisplayServer *)> server_ready)

I'd suggest the configuration object deals with the command line. Vis:

mir::DefaultServerConfiguration::DefaultServerConfiguration(int argc, char const**argv);

If a callback is needed, then why not add that to DisplayServer::start()?

[Robert Carr (robertcarr)]

Fixed through the server configuration changes and mir::run_mir

[Daniel van Vugt (vanvugt)]

Which branch fixed it?