Bazaar does not indicate which file already exists with Error 17

[Jo Vermeulen]

This occured when checking out the same file twice during checkout on case-insensitive filesystems (Windows in this case). It would be helpful for the user if he could see which files have the same name according to Bazaar, in order to be able to easily rename them (to make them work on case-insensitive filesystems).

[John A Meinel (jameinel)]

Even something as simple as:
=== modified file 'bzrlib/transform.py'
--- bzrlib/transform.py 2007-03-26 19:39:14 +0000
+++ bzrlib/transform.py 2007-05-02 14:45:44 +0000
@@ -817,6 +817,8 @@
                     except OSError, e:
                         # We may be renaming a dangling inventory id
                         if e.errno != errno.ENOENT:
+ warning('Could not create file: %s\n%s',
+ full_path, e)
                             raise
                     if trans_id in self._new_contents:
                         modified_paths.append(full_path)

would help.

[John A Meinel (jameinel)]

Since LP messed up my spacing, I'm uploading a diff.

[Jo Vermeulen (jozilla)]

Indeed, that would already be useful. Will it also print out the path of the file? Or just the filename? In my opinion, a path would be better (for knowing in which subfolder the file clash occured).

[John A Meinel (jameinel)]

As the variable is called "full_path" I think it is the absolute path of the file on disk. So it includes the working directory '/home/user/project/path/to/foo', not "foo" or "path/to/foo"

[Alexander Belchenko (bialix)]

Patch for John Meinel should not be used. Comment from Aaron Bentley:

> As discussed on the list, we should raise an exception containing the path info, instead of putting it in a warning. That should be easier to test, too.

[Martin Pool (mbp)]

I can see an rfc for this on the list, but not an approved patch, so I'm going to defer it to the next rc.

[Alexander Belchenko (bialix)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool пишет:
> I can see an rfc for this on the list, but not an approved patch, so I'm
> going to defer it to the next rc.

Currently Aaron merged patch that prevent to raise error in the code this bug about.
So we less likely will be able to get this error now.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHT8n9zYr338mxwCURApM+AJ9Dyui/rzQutzF2jUFK41rvyGGowQCdH0sd
ZS9u0izZQ9yqEqIOsay65i4=
=+8hO
-----END PGP SIGNATURE-----