Needless flush list mutex reacquisitions in adaptive flushing
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
5.1 |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
5.5 |
Fix Released
|
Medium
|
Laurynas Biveinis |
Bug Description
Introduced by bug 1083058 fix, credit to Sergei.
One of adaptive flushing bits in srv_master_thread() reads
mutex_
flushed_
- blocks_num;
if (flushed_blocks_num < 0) {
flushed_
}
mutex_
bpage = UT_LIST_
prev_
if (bpage) {
prev_
prev_
prev_
mutex_
} else {
mutex_
prev_
prev_
prev_
}
It makes no sense to release the flush list mutex for such a short duration and then reacquire it for very short duration again.
Related branches
- Stewart Smith (community): Approve
- Registry Administrators: Pending requested
-
Diff: 19 lines (+0/-2)1 file modifiedPercona-Server/storage/innodb_plugin/srv/srv0srv.c (+0/-2)
- Stewart Smith (community): Approve
- Registry Administrators: Pending requested
-
Diff: 19 lines (+0/-2)1 file modifiedPercona-Server/storage/innobase/srv/srv0srv.c (+0/-2)
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/ /jira.percona. com/browse/ PS-1311