Incorrect copyright notice on Hyper-V driver

[Donal Lafferty]

The files vmutils.py and vmops.py represent themselves as an original contribution from Cloudbase Solutions Srl

However, they are clearly derivatives of earlier work by Cloud.com

The Cloud.com copyright accompanying the original contribution should be added to the files to the files above. Other files in the driver should be inspected to see if they too are derivatives. Previous versions of OpenStack also need to be updated.

[Alessandro Pilotti (alexpilotti)]

My bad, by creating new files during refactoring I didn't include the original copyright notes which are still left in the "driver.py" file. Even if the code has changed a lot since the original pre-Essex code released by Cloud.com it's absolutely correct to include the copyright notice in the new files.

It's anyway very interesting how, by looking at the following Cloudstack blueprint which provides a Hyper-V driver, I found our OpenStack Python code included in the implementation (keeping the correct copyright notices), with a Java wrapper on top:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Hyper-V+2012+%283.0%29+Support

Here's the relevant implementation:

https://github.com/lafferty/cshv3/tree/master/plugins/hypervisors/hyperv/scripts/hyperv

So if this will be merged, Cloudstack will be in part an OpenStack derivative :-)

Again, I'm very sorry sorry for my inadvertence, I'm going to add the copyright notice right away.

[Donal Lafferty (donal-lafferty)]

The CloudStack mailing list already explains that the code copyrighted by Alessandro has been removed in favour of the original version by Cloud.com. There are less files involved and a better chance of getting it donated by Cloud.com

Unfortunately, the Apache folks don't like 3rd party code, as I'm finding out. It is unlikely that OpenStack code will find its way into CloudStack :(

In the meantime, keep up the good work!

[Alessandro Pilotti (alexpilotti)]

Hi Donald,

We are also working since some time on a Hyper-V CloudStack driver, I'm going to contact you to see if we can contribute it!

About our OpenStack Python code, if there's a way we can contribute that one as well, I'd be happy to do that.

Thanks and sorry again for the glitch! :-)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/21274

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/21274
Committed: http://github.com/openstack/nova/commit/df5ab5aeceaf634610f99cce593de1be101f71fc
Submitter: Jenkins
Branch: master

commit df5ab5aeceaf634610f99cce593de1be101f71fc
Author: Alessandro Pilotti <email address hidden>
Date: Wed Feb 6 02:43:45 2013 +0200

    Adds original copyright notice to refactored files

    Fixes bug: #1116586

    The Hyper-V driver contributed for Folsom contains some refactored code
    from the Diablo release contributed by Cloud.com.

    Although the copyright notice remained in the "driver.py" file, it has
    erroneously not been added to the new "vmops.py" and "vmutils.py" files
    that contained some refactored code from the original contribution.

    Change-Id: I71cf1df30c0b2ef5ae3df38f3c6f0311b7b4b3d9