[MIR] grilo

[Timo Jyrinki]

Availability: in universe: amd64, i386, armhf, powerpc

Rationale: Connected devices can easily share videos, music etc. with each other, but the prerequisite is an application that supports DLNA/UPnP. Accepting grilo to main would make it possible to not explicitly disable grilo support in totem. See bug #1035701.
Another important rationale is the requirement of grilo for mediascanner to get included into main, as this is one of its dependencies. Mediascanner will be used by unity scopes and some Ubuntu Touch apps.

Security: No known security history.

QA: No outstanding bug reports in either Debian (one wishlist item) - http://bugs.debian.org/cgi-bin/pkgreport.cgi?repeatmerged=no&src=grilo - or Ubuntu (none) - https://bugs.launchpad.net/ubuntu/+source/grilo. debian/watch file included, latest version packaged.

Dependencies: All dependencies in main.

Maintenance: Debian maintainer has been regularly updating the package since June 2011, latest upload in December 2012.

Other: This is required to fix bug #1035701 (Totem) and bug #973295 (Rhythmbox). I have a test build of Totem with grilo enabled uploaded to https://launchpad.net/~timo-jyrinki/+archive/ppa. I tested Grilo with Totem to successfully stream music from my DAAP server and video from my Nokia N9 phone over DLNA.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Michael Terry (mterry)]

Jason, can you confirm if grilo is something the Desktop team wants by default? I believe it allows Jamendo and UPnP for Rhythmbox and UPnP for Totem.

[Jason Warner (jasoncwarner)]

Mike - This functionality is generally useful and often requested. Sounds good to get it in!

[Michael Terry (mterry)]

I'm looking at grilo, and it seems mostly fine (except a test suite that isn't being run; I'm looking at enabling that). However... grilo also pulls in grilo-plugins via a recommends (and needs it to actually be useful).

grilo-plugins looks to be more problematic. There are additional packages that would need to enter main (libgupnp-av-1.0-dev and libtracker-sparql-0.14-dev), and there would need to be a security review, which I'm guessing would turn up a couple things.

So... A few options:
 * Move grilo-plugins from Recommends to Suggests for grilo. That allows us to build totem and rhythmbox with support for grilo, and drop that delta. Users and flavors could still install grilo-plugins if desired.
 * Review the plugins and split grilo-plugins into main-acceptable ones and ones that should stay in universe.
 * Review the plugins and disable the ones that aren't main-acceptable.

Timo, you asked for grilo. Do you have an opinion?

[Michael Terry (mterry)]

Enabling the grilo tests is more complicated than I have time for right now. I filed bug 1119781 in Ubuntu, and linked it to an upstream bug I filed. If someone can push that along, that would be great. That's likely a blocker for MIR too.

[Timo Jyrinki (timo-jyrinki)]

Ah, darn, so build dependencies were fulfilled but I missed grilo-plugins. I think grilo-plugins should be split, it's the UPnP/DLNA (libgupnp-av-1.0-dev) support that most users desire I believe. And on the other hand, the Tracker is the only additional plugin requiring universe dependencies so it could be just trivial enough to disable Tracker plugin (I doubt it's very highly used). Additionally gupnp-av should be MIR:d (gupnp happily already is in main).

I'm not having the luxury of a lot of free time to start to look at this at this point, but here is the plan that would need to be done if grilo is wanted to be enabled:
1. enable tests in grilo source
2. MIR gupnp-av source package
3. disable tracker plugin and remove the tracker dependency in grilo-plugins source
4. MIR grilo-plugins (or as part of this bug since they both are needed to be done at the same time)

[Jeremy Bícha (jbicha)]

Michael and Timo, Debian has switched the recommends on grilo-plugins to suggests.

Looking at Totem & Rhythmbox's configure.ac, it seems that libgrilo is sufficient for them to build with grilo.
So maybe grilo-plugins aren't needed in main, at least not yet?

[Michael Terry (mterry)]

Jeremy, that's good news about the Suggests. That just leaves bug 1119781 about enabling the grilo tests.

[Łukasz Zemczak (sil2100)]

I think we'll need to re-consider inclusion of this package into main, due to the fact it's one of the mediascanner dependencies, which we want to release into main. Updating description. I guess bug #1119781 is still valid?

[Michael Terry (mterry)]

Yeah, I'm still bothered by the tests being bitrotten and additionally upstream not caring enough to fix them in the couple months since they were notified.

What team will look after this in Ubuntu? They should be subscribed to bug reports and fix up the tests to run.

[Alberto Garcia (berto)]

Hey, I'm the Debian maintainer of Grilo.

As upstream mentioned in bug #1119781, those tests don't need to be fixed because they never worked.

As far as I'm aware it was just an initial skeleton of a work that was never completed.

About splitting the Grilo plugins package, I also think it's a good idea, I would actually like to do that in Debian at some point.

[Michael Terry (mterry)]

Tests that aren't finished being written I can forgive. But they should really be finished!

That just leaves a bug subscriber. Can we get a team bug subscriber for whichever team is going to look after this in Ubuntu?

[Timo Jyrinki (timo-jyrinki)]

I've contacted mhall119 / jhodapp to add Ubuntu Multimedia Developers with 38 members to grilo. I'll update the bug once that happens.

[Juan A. Suárez Romero (jasuarez-deactivatedaccount-deactivatedaccount)]

It is not that we need to finish them: we need to write them from scratch. The tests you see were just an attempt to start, but never success.

So forget about there "tests" directory: i'm going to remove that for next release.

But, if the question is: "grilo does not have any test, and should", my answer is: totally agree.

[Timo Jyrinki (timo-jyrinki)]

Team subscribed to the bugs.

[Michael Terry (mterry)]

Juan, yeah, my point was just that I like working tests, however they get done. :)

One last note. Can this please be updated to work with valac-0.22? Since this MIR got filed, valac-0.20 got demoted to universe because nothing in main needed it anymore, and I'd like to avoid promoting it again if I can.

[Juan A. Suárez Romero (jasuarez-deactivatedaccount-deactivatedaccount)]

I think Vala 0.22 is already added in upstream.

[Michael Terry (mterry)]

Yeah, it probably is as simple as updating the build-dep, so should be easy.

[Launchpad Janitor (janitor)]

[Expired for grilo (Ubuntu) because there has been no activity for 60 days.]

[Juan A. Suárez Romero (jasuarez-deactivatedaccount-deactivatedaccount)]

This bug has been closed due lack of activity.

Is anyone working on it?

[Michael Terry (mterry)]

This just needs a build-dep update to fix the valac version used.

[Timo Jyrinki (timo-jyrinki)]

I checked the 0.2.10-1 that got just uploaded and it build-deps on 'valac' only.

I believe grilo is not planned to be used by Touch indefinitely, but Totem/Rhythmbox on the desktop would still benefit from being able to play DLNA sources.

[Michael Terry (mterry)]

OK, approved then! Thanks.

[Juan A. Suárez Romero (jasuarez-deactivatedaccount-deactivatedaccount)]

Timo, do you know what Touch will use instead grilo?

[Timo Jyrinki (timo-jyrinki)]

Juan: I'd look towards https://code.launchpad.net/mediascanner2 and https://code.launchpad.net/media-hub but I'm not sure about their features or roadmap, ie would grilo still be needed for some features.

[Jim Hodapp (jhodapp)]

No future plans at this time to use grilo for media-hub.

[Timo Jyrinki (timo-jyrinki)]

Michael: When could we expect for the move to come into fruition? It'd be nice to enable Rhythmbox building with grilo among else.

[Michael Terry (mterry)]

Timo, you should be able to start using it today. Once something else in main needs grilo, the archive admins will promote it. So go ahead and update rhythmbox to build-dep on it.