pcb

Print dialog internationalization

Bug #1113727 reported by Sergey Alyoshin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pcb
Fix Released
Low
Bert Timmerman

Bug Description

Print dialog internationalization.

Tags: i18n
Revision history for this message
Sergey Alyoshin (alyoshin-s) wrote :
Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Hi Sergey,

I can't see how a line like:

    widget = gtk_label_new (_(attrs[j].name));

is translatable at build-time, when it holds the translatable string only during run-time.

However, I am sure I am missing a lot of knowledge regarding the gettext voodoo ;-)

Kind regards,

Bert Timmerman.

Revision history for this message
Sergey Alyoshin (alyoshin-s) wrote :

> widget = gtk_label_new (_(attrs[j].name));

You are right. For this to work relevant strings should be marked with N_().
Please see attached patch.

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Hi Sergey,

Does the 0001 patch still needs to be applied, or does it need to be revoked ?

Kind regards,

Bert Timmerman.

Changed in pcb:
status: New → Confirmed
assignee: nobody → Bert Timmerman (bert-timmerman)
importance: Undecided → Low
status: Confirmed → In Progress
Revision history for this message
Sergey Alyoshin (alyoshin-s) wrote : Re: [Bug 1113727] Re: Print dialog internationalization

On Sun, Jan 26, 2014 at 3:02 PM, Bert Timmerman
<email address hidden> wrote:
> Hi Sergey,
>
> Does the 0001 patch still needs to be applied, or does it need to be
> revoked ?

Yes, 0001 still needs. In 0001 for strings, which marked as translatable in 0002
with N_(), actual translation function _() is called.

> ** Changed in: pcb
> Status: New => Confirmed
>
> ** Changed in: pcb
> Assignee: (unassigned) => Bert Timmerman (bert-timmerman)
>
> ** Changed in: pcb
> Importance: Undecided => Low
>
> ** Changed in: pcb
> Status: Confirmed => In Progress
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1113727
>
> Title:
> Print dialog internationalization
>
> Status in PCB: Printed Circuit Board CAD package:
> In Progress
>
> Bug description:
> Print dialog internationalization.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/pcb/+bug/1113727/+subscriptions

Changed in pcb:
status: In Progress → Fix Committed
Changed in pcb:
status: Fix Committed → Fix Released
Changed in pcb:
milestone: none → pcb-20140316
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.