[Trunk/7.0] Typo :1 Sales, 1 Purchases, 1 Meetings, 1 Opportunities on Customer KANBAN instead of 1 Sale, 1 Purchase, 1 Meeting, 1 Opportunity

Bug #1112985 reported by Ray Carnes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Committed
Low
OpenERP R&D Addons Team 3

Bug Description

The Kanban view will currently show Customers with the number of Sales listed, but when there is only one sale, it shows:

1 Sales

instead of

1 Sale

1) Steps to reproduce the issue you have observed

Sales --> Sales --> Customers

2) The result you observed

1 Sales

3) The result you expected

1 Sale

4) The platform you are using

Ubuntu 12.04

5) The browser and browser version you are using

Firefox, Chrome and Internet Explorer

6) The OpenERP version you are using

7.0

I also tested today on http://7-0-2855.runbot.openerp.com and had the same experience

7) Suggested fix

A way to fix this is to change the sale.crm_lead_partner_kanban_view view.

Original XML:

<?xml version="1.0"?>
<data><field name="mobile" position="after">
                    <field name="sale_order_count"/>
                </field>
                <xpath expr="//div[@class='oe_kanban_partner_links']" position="inside">
                    <a name="503" type="action" t-if="record.sale_order_count.value&gt;0">
                        <t t-esc="record.sale_order_count.value"/> Sales
                    </a>
                </xpath>
            </data>

New XML:

<?xml version="1.0"?>
<data><field name="mobile" position="after">
                    <field name="sale_order_count"/>
                </field>
                <xpath expr="//div[@class='oe_kanban_partner_links']" position="inside">
                    <a name="503" type="action" t-if="record.sale_order_count.value&gt;1">
                        <t t-esc="record.sale_order_count.value"/> Sales
                    </a>
                    <a name="503" type="action" t-if="record.sale_order_count.value==1">
                        <t t-esc="record.sale_order_count.value"/> Sale
                    </a>
                </xpath>
            </data>

8) Additional Information

This issue also applies to:

Opportunities and Meetings, in crm.crm_lead_partner_kanban_view.
Purchases in purchase.purchase_partner_kanban_view.

This is applicable not just in English:

vente, ventes in French - don't they speak that in Belgium ;)

Related branches

summary: - 1 Sales, 1 Purchases, 1 Meetings, 1 Opportunities on Customer KANBAN
- instead of 1 Sale, 1 Purchase, 1 Meeting, 1 Opportunity
+ [Trunk] Typo :1 Sales, 1 Purchases, 1 Meetings, 1 Opportunities on
+ Customer KANBAN instead of 1 Sale, 1 Purchase, 1 Meeting, 1 Opportunity
affects: openerp-web → openobject-addons
Changed in openobject-addons:
status: New → Confirmed
importance: Undecided → Low
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Chandni Gandhi(OpenERP) (cga-openerp) wrote : Re: [Trunk] Typo :1 Sales, 1 Purchases, 1 Meetings, 1 Opportunities on Customer KANBAN instead of 1 Sale, 1 Purchase, 1 Meeting, 1 Opportunity

Hello,

It has been fixed in to https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1112985-cga

Revision No:8531
Revision ID:<email address hidden>

It will be merged soon.

Thanks

Changed in openobject-addons:
status: In Progress → Fix Committed
summary: - [Trunk] Typo :1 Sales, 1 Purchases, 1 Meetings, 1 Opportunities on
+ [Trunk/7.0] Typo :1 Sales, 1 Purchases, 1 Meetings, 1 Opportunities on
Customer KANBAN instead of 1 Sale, 1 Purchase, 1 Meeting, 1 Opportunity
Revision history for this message
Chandni Gandhi(OpenERP) (cga-openerp) wrote :

Hello ,

For 7.0 it has been fixed in to : https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-bug-1112985-cga

Revision No:8674
Revision ID:<email address hidden>

It will be merged soon.

Thanks.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.