git-buildpackage incorrectly handles --notify command line parameter

[Volodymyr Kolesnykov]

Sample run:

$ git-buildpackage --git-verbose --notify=off --git-upstream-branch=master --git-force-create --git-upstream-tag=master -S -sa
gbp:debug: ['git', 'rev-parse', '--show-cdup']
gbp:debug: ['git', 'rev-parse', '--is-bare-repository']
gbp:debug: debuild -d clean [] []
dh clean
   dh_testdir
   debian/rules override_dh_auto_clean
make[1]: Вход в каталог `/var/www/git/php-chuid'
dh_auto_clean
phpize5 --clean
Cleaning..
rm -rf debian/chuid.ini tmp-php.ini
make[1]: Выход из каталога `/var/www/git/php-chuid'
   dh_clean
gbp:debug: ['git', 'status']
gbp:debug: ['git', 'symbolic-ref', 'HEAD']
gbp:debug: ['git', 'show-ref', 'refs/heads/master']
gbp:debug: ['git', 'show-ref', 'refs/heads/pristine-tar']
gbp:debug: ['git', 'ls-tree', 'master']
gbp:info: php-chuid_0.5.0.orig.tar.gz does not exist, creating from 'master'
gbp:debug: Building upstream tarball with compression 'gzip -9'
gbp:debug: debuild -i -I ['--notify=off', '-S', '-sa'] []
debuild: unknown dpkg-buildpackage/debuild option: --notify=off

In this case "--notify=off" is incorrectly passed to dpkg-buildpackage.
Moreover, after the build fails (due to "unknown dpkg-buildpackage/debuild option: --notify=off"), I still receive a desktop notification though --notify=off should have disabled it.

$ apt-cache policy git-buildpackage
git-buildpackage:
  Installed: 0.6.0~git20120601
  Candidate: 0.6.0~git20120601
  Version table:
 *** 0.6.0~git20120601 0
        500 http://ua.archive.ubuntu.com/ubuntu/ quantal/universe amd64 Packages
        100 /var/lib/dpkg/status

[Guido Günther (agx)]

That's actually a bug in the manpage. It's missing the --git- prefix:

https://honk.sigxcpu.org/gitweb/?p=git-buildpackage.git;a=commit;h=80b5c649a62a9fc1297e2345654f94ef762572b3

[Volodymyr Kolesnykov (sjinks)]

Yes, you are right — --git-notify works fine, thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package git-buildpackage - 0.6.0~git20130414

---------------
git-buildpackage (0.6.0~git20130414) unstable; urgency=low

  * [e948bd3] Don't try access source before it's filled

 -- Guido Günther <email address hidden> Sat, 13 Apr 2013 19:36:57 +0200