allowvssprovider=false not honored in other_config field

Bug #1112673 reported by Nicholas Kuechler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Nicholas Kuechler

Bug Description

Currently we're setting allowvssprovider=false in the other-config field. However, this setting is not honored in the other-config field, allowing vss-based snapshots to be created.

The allowvssprovider=false should be moved to the vm-data field in xenstore as that field is used to decide whether vss snapshotting is allowed or not.

Relevant code:

https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vm_utils.py#L233

Manually set allowvssprovider=false in the vm-data field:

xe vm-param-set uuid=<VM-UUID> xenstore-data:vm-data/allowvssprovider=false

References:

https://github.com/mcclurmc/xcp-storage-managers/blob/master/drivers/vss_control#L38
https://github.com/mcclurmc/xcp-storage-managers/blob/master/snapwatchd/snapwatchd#L298

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21029

Changed in nova:
assignee: nobody → Nicholas Kuechler (nicholaskuechler)
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/21029
Committed: http://github.com/openstack/nova/commit/8ddbbf095136333cb9f2f4c7d60e37f70c759776
Submitter: Jenkins
Branch: master

commit 8ddbbf095136333cb9f2f4c7d60e37f70c759776
Author: Nicholas Kuechler <email address hidden>
Date: Fri Feb 1 11:04:01 2013 -0600

    Move allowvssprovider=false to vm-data field

    Currently we're setting allowvssprovider=false in the other-config
    field. However, this setting is not honored in the other-config field,
    allowing vss-based snapshots to be created.

    The allowvssprovider=false should be moved to the vm-data field in
    xenstore as that field is used to decide whether vss snapshotting is allowed or not.

    Amended to change: 'str(False)' to 'false'.

    Relevant code:

    https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vm_utils.py#L233

    Manually set allowvssprovider=false in the vm-data field:

    xe vm-param-set uuid=<VM-UUID> xenstore-data:vm-data/allowvssprovider=false

    References:

    https://github.com/mcclurmc/xcp-storage-managers/blob/master/drivers/vss_control#L38
    https://github.com/mcclurmc/xcp-storage-managers/blob/master/snapwatchd/snapwatchd#L298

    Change-Id: I96efbc18cb7eb0ee2d0e6526b3c4f3502a68e1dd
    Fixes: bug #1112673

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
Revision history for this message
Nicholas Kuechler (nicholaskuechler) wrote :

The bug is still present. My previous fix is problematic and I have the proper fix incoming.

Changed in nova:
status: Fix Released → Incomplete
Changed in nova:
status: Incomplete → In Progress
tags: added: xenserver
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/45458
Committed: http://github.com/openstack/nova/commit/6f753deea83f340181bf7bbc602c80e47276f122
Submitter: Jenkins
Branch: master

commit 6f753deea83f340181bf7bbc602c80e47276f122
Author: Nicholas Kuechler <email address hidden>
Date: Fri Oct 4 13:34:20 2013 -0500

    Update allowvssprovider in xenstore_data

    My previous commit was missing the vm-data part so the original
    bug was still present.

    The command line fix:
    xe vm-param-set uuid={UUID} xenstore-data:vm-data/allowvssprovider=false

    This commit adds vm-data to the xenstore message and will properly
    disallow vss.

    Fixes: bug #1112673

    Change-Id: I85ef25a9b61795c98c12549f77cd7ca7305861d2

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.