Remove BeatHighlightColor in the waveform

[jus]

<BeatHighlightColor> blinks for a brief about of time to indicate when the beat is near the playposition. If a skin.xml does not define a BeatHighlightColor (this is what we currently do), it defaults to black . BeatHighlightColor gives a 2px "ghost" image which is pretty much invisible and therefore useless imo. We should remove the <BeatHighlightColor> key without replacement.

The idea to indicate beats is a good one generally, but the type of implementation needs to be improved in Mixxx. In practice, a phase/beat indicator as seen at competitors is more useful, see lp:753301 & lp:888810. For now, removing the BeatHighlightColor and painting an emphasized downbeat marker is probably the quickest solution for the moment.

[jus (jus)]

Attached patch removes BeatHighlightColor .
Please check if done correctly and whether removing BeatHighlightColor is ok for you.
Once committed, i'll delete the key from the skin.xml's as well.

[Daniel Schürmann (daschuer)]

I did not compile your patch but, from the code review side it looks fine!

[jus (jus)]

2nd version of the patch additionally removes the key from all skin.xml and updates changelog and version info accordingly. Any objections?

[Daniel Schürmann (daschuer)]

No :-)

[RJ Skerry-Ryan (rryan)]

lgtm

On Fri, Apr 12, 2013 at 6:32 AM, Daniel Schürmann <
<email address hidden>> wrote:

> No :-)
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1112396
>
> Title:
> Remove BeatHighlightColor in the waveform
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1112396/+subscriptions
>

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6884