Object inequality evaluation syntax nits

Bug #1110987 reported by Zhongyue Luo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Zhongyue Luo

Bug Description

There are some lines in cinder where instead of "if X is not Y", it uses "if not X is Y"

Since "is not" seems to be the consensus and is more intuitive, object inequality evaluations should use "is not"

$ grep -R " not " cinder | grep " is " | grep -v " is not " | grep -E ":\W*if" |wc -l
6
$ grep -R " not " cinder | grep " is " | grep -E ":\W*if" |wc -l
108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/20866

Changed in cinder:
assignee: nobody → Zhongyue Luo (zyluo)
status: New → In Progress
Zhongyue Luo (zyluo)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/20866
Committed: http://github.com/openstack/cinder/commit/8960e4d33c73d79778aa02cfed0c7691a3b7e158
Submitter: Jenkins
Branch: master

commit 8960e4d33c73d79778aa02cfed0c7691a3b7e158
Author: Zhongyue Luo <email address hidden>
Date: Thu Jan 31 10:31:51 2013 +0800

    Fixes "is not" usage

    Fixes bug #1110987

    Change-Id: Iafa9fc548deaf03c229cc9144d85e6c68b3101be

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.