nginx_requests is inconsistent with documentation (and nginx_status)

Bug #1110371 reported by Viktor Petersson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
munin (Ubuntu)
Confirmed
Medium
Unassigned

Bug Description

There are two Nginx-plugins: nginx_status and nginx_requests. According to the documentation inside the packages, both packages should default to http://localhost/nginx_status for retrieval of status from Nginx. That is however untrue for nginx_requests, which expects the http://FQDN/nginx_status.

This can of course be overridden in /etc/munin/plugin-conf.d/munin-node, but it would make a whole lot sense if both plugins behaved the same way by default.

To resolve this, here's a patch for nginx_requests that changes it to behave the same way as nginx_status:

64,66c64
< chomp(my $fqdn=`hostname -f 2>/dev/null | hostname`);
<
< my $URL = exists $ENV{'url'} ? $ENV{'url'} : "http://$fqdn/nginx_status";
---
> my $URL = exists $ENV{'url'} ? $ENV{'url'} : "http://localhost/nginx_status";

Tags: patch
Changed in munin (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
tags: added: patch
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.