Hold note count and text not displayed

[Kyle Tomita]

This is a bug regarding the "Hold Note(s) Count" and "Hold Note(s) Text" are not populated on the Patron Holds List View, Patron Holds Details View, Bib Record List View, and Bib Record Details View. The hold has 1 or more notes and the count stays at 0 and the Hold Note(s) Text column is empty.

This is related to Bug #691597 but expands it to include List views as well and includes the Hold Note(s) Text column.

Added screenshots in comments.

[Kyle Tomita (tomitakyle)]

Hold Note count and text not displayed in Bib Record Hold Details View

[Kyle Tomita (tomitakyle)]

Hold Note count and text not displayed in Bib Record Hold List View

[Kyle Tomita (tomitakyle)]

Hold Note count and text not displayed in Patron Hold Details View

[Kyle Tomita (tomitakyle)]

Hold Note count and text not displayed in Patron Hold List View

[Kyle Tomita (tomitakyle)]

Branch with solution

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/catalystit/Bug1109316

[Pasi Kallinen (paxed)]

The "Hold Note(s) Count" and "Hold Note(s) Text" column update just fine when the hold type is 'C'; this happens (only?) when the hold type is 'T'.

Tested the branch above, and the fix works. My signoff at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/lp1109316-signoff

[Kyle Tomita (tomitakyle)]

Here is a branch with the fix applied to Evergreen rel 2.2.5
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/catalystit/Bug1109316_rel225

Here is a branch with the fix applied to Evergreen rel 2.3.3
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/catalystit/Bug1109316_rel233

[Dan Wells (dbw2)]

Kyle, thanks for reporting and working out a solution to this bug. I wonder, though, whether this fix is the right direction to go.

It seems at one time the hold "blob" had the notes attached, then they disappeared. Tracing the problem back a step further, then, it looks like the hold fetching code has a logic error on the server side. Basically, it is hiding staff notes from the staff instead of the user (and vice versa).

Here is a branch to address that problem, which in turn fixes the client display:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/hold_blob_note_fetch

working/user/dbwells/hold_blob_note_fetch

In addition, I have pushed an additional commit on this branch to allow public notes to be seen in appropriate cases. While not strictly part of this bug, it seems sensible to include it, provided my understanding of the original intentions are correct.

Finally, I didn't check all the variations of this bug, so please report back if this doesn't solve them all, and we can see what additional work needs to be done.

[Kyle Tomita (tomitakyle)]

Tested Dan's solution and it works with current master, here is my branch, http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/catalystit/lp1109316-signoff

[Kyle Tomita (tomitakyle)]

Ported over the solution to 2.2 and 2.3 in these branches respectively,

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=log;h=refs/heads/user/catalystit/lp1109316_rel_2_2

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=log;h=refs/heads/user/catalystit/lp1109316_rel_2_3

[Dan Wells (dbw2)]

Pushed to master, rel_2_3, and rel_2_2. Thank you very much for testing, Kyle.