response 500 when boot with a image not active

[Zhou ShaoYu]

2013-01-29 10:52:24 ERROR nova.api.openstack [req-a2a22ec6-4f62-4504-b6ba-c98ede5a85d3 f2665c1140c54a03a98110cb86262ec3 dc32392af0ae4a098fb7235760077fa6] Caught error: Image 1a784490-5ee0-420a-9122-2d196f8677a4 is not active.
2013-01-29 10:52:24 TRACE nova.api.openstack Traceback (most recent call last):
2013-01-29 10:52:24 TRACE nova.api.openstack File "path/nova/api/openstack/__init__.py", line 78, in __call__
2013-01-29 10:52:24 TRACE nova.api.openstack return req.get_response(self.application)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/webob/request.py", line 1053, in get_response
2013-01-29 10:52:24 TRACE nova.api.openstack application, catch_exc_info=False)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/webob/request.py", line 1022, in call_application
2013-01-29 10:52:24 TRACE nova.api.openstack app_iter = application(self.environ, start_response)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/webob/dec.py", line 159, in __call__
2013-01-29 10:52:24 TRACE nova.api.openstack return resp(environ, start_response)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/keystone/middleware/auth_token.py", line 176, in __call__
2013-01-29 10:52:24 TRACE nova.api.openstack return self.app(env, start_response)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/webob/dec.py", line 159, in __call__
2013-01-29 10:52:24 TRACE nova.api.openstack return resp(environ, start_response)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/webob/dec.py", line 159, in __call__
2013-01-29 10:52:24 TRACE nova.api.openstack return resp(environ, start_response)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/webob/dec.py", line 159, in __call__
2013-01-29 10:52:24 TRACE nova.api.openstack return resp(environ, start_response)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/routes/middleware.py", line 131, in __call__
2013-01-29 10:52:24 TRACE nova.api.openstack response = self.app(environ, start_response)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/webob/dec.py", line 159, in __call__
2013-01-29 10:52:24 TRACE nova.api.openstack return resp(environ, start_response)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/webob/dec.py", line 147, in __call__
2013-01-29 10:52:24 TRACE nova.api.openstack resp = self.call_func(req, *args, **self.kwargs)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/local/lib/python2.7/dist-packages/webob/dec.py", line 208, in call_func
2013-01-29 10:52:24 TRACE nova.api.openstack return self.func(req, *args, **kwargs)
2013-01-29 10:52:24 TRACE nova.api.openstack File "path/nova/api/openstack/wsgi.py", line 885, in __call__
2013-01-29 10:52:24 TRACE nova.api.openstack content_type, body, accept)
2013-01-29 10:52:24 TRACE nova.api.openstack File "path/nova/api/openstack/wsgi.py", line 933, in _process_stack
2013-01-29 10:52:24 TRACE nova.api.openstack action_result = self.dispatch(meth, request, action_args)
2013-01-29 10:52:24 TRACE nova.api.openstack File "path/nova/api/openstack/wsgi.py", line 1021, in dispatch
2013-01-29 10:52:24 TRACE nova.api.openstack return method(req=request, **action_args)
2013-01-29 10:52:24 TRACE nova.api.openstack File "path/nova/api/openstack/compute/servers.py", line 855, in create
2013-01-29 10:52:24 TRACE nova.api.openstack scheduler_hints=scheduler_hints)
2013-01-29 10:52:24 TRACE nova.api.openstack File "path/nova/compute/api.py", line 812, in create
2013-01-29 10:52:24 TRACE nova.api.openstack scheduler_hints=scheduler_hints)
2013-01-29 10:52:24 TRACE nova.api.openstack File "path/nova/compute/api.py", line 531, in _create_instance
2013-01-29 10:52:24 TRACE nova.api.openstack QUOTAS.rollback(context, quota_reservations)
2013-01-29 10:52:24 TRACE nova.api.openstack File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
2013-01-29 10:52:24 TRACE nova.api.openstack self.gen.next()
2013-01-29 10:52:24 TRACE nova.api.openstack File "path/nova/compute/api.py", line 421, in _create_instance
2013-01-29 10:52:24 TRACE nova.api.openstack raise exception.ImageNotActive(image_id=image_id)
2013-01-29 10:52:24 TRACE nova.api.openstack ImageNotActive: Image 1a784490-5ee0-420a-9122-2d196f8677a4 is not active.
2013-01-29 10:52:24 TRACE nova.api.openstack
2013-01-29 10:52:24 INFO nova.api.openstack [req-a2a22ec6-4f62-4504-b6ba-c98ede5a85d3 f2665c1140c54a03a98110cb86262ec3 dc32392af0ae4a098fb7235760077fa6] http://localhost:8774/v2/dc32392af0ae4a098fb7235760077fa6/servers returned with HTTP 500
2013-01-29 10:52:24 INFO nova.osapi_compute.wsgi.server [req-a2a22ec6-4f62-4504-b6ba-c98ede5a85d3 f2665c1140c54a03a98110cb86262ec3 dc32392af0ae4a098fb7235760077fa6] 127.0.0.1 - - [29/Jan/2013 10:52:24] "POST /v2/dc32392af0ae4a098fb7235760077fa6/servers HTTP/1.1" 500 335 1.446659

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/20675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/20675
Committed: http://github.com/openstack/nova/commit/84a83c67d81f41c00ca9259ebebec97e6e7788bb
Submitter: Jenkins
Branch: master

commit 84a83c67d81f41c00ca9259ebebec97e6e7788bb
Author: Zhou ShaoYu <email address hidden>
Date: Tue Jan 29 15:33:46 2013 +0800

    Fix boot with image not active

    When boot with image which is not active, nova API response
    with http status code 500. We should catch the exception and
    raise HTTPBadRequest with more precise information.

    Fix LP# 1108645

    Change-Id: Ibd78f4b96bfdb925b03d7809d4e28afcc7e1ddcf